dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 12:51:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(semantic): connect test expression of for statements to the cfg. (#3122)

Browse source 
I don't know if it is correct or not, Fixes my issues with dangling cfg nodes created in for statements. #3071
This commit is contained in:
Ali Rezvani 2024-05-10 17:41:25 +03:30 committed by GitHub
parent 18d853bb2b
commit c91d26129c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/oxc_semantic/src/builder.rs
View file

@ -785,6 +785,7 @@ impl<'a> Visit<'a> for SemanticBuilder<'a> {
} }
/* cfg */ /* cfg */
let after_test_graph_ix = self.cfg.current_node_ix;
let update_graph_ix = self.cfg.new_basic_block(); let update_graph_ix = self.cfg.new_basic_block();
/* cfg */ /* cfg */
@ -803,10 +804,10 @@ impl<'a> Visit<'a> for SemanticBuilder<'a> {
/* cfg */ /* cfg */
let after_for_stmt = self.cfg.new_basic_block(); let after_for_stmt = self.cfg.new_basic_block();
self.cfg.add_edge(before_for_graph_ix, test_graph_ix, EdgeType::Normal); self.cfg.add_edge(before_for_graph_ix, test_graph_ix, EdgeType::Normal);
self.cfg.add_edge(test_graph_ix, body_graph_ix, EdgeType::Normal); self.cfg.add_edge(after_test_graph_ix, body_graph_ix, EdgeType::Normal);
self.cfg.add_edge(body_graph_ix, update_graph_ix, EdgeType::Backedge); self.cfg.add_edge(body_graph_ix, update_graph_ix, EdgeType::Backedge);
self.cfg.add_edge(update_graph_ix, test_graph_ix, EdgeType::Backedge); self.cfg.add_edge(update_graph_ix, test_graph_ix, EdgeType::Backedge);
self.cfg.add_edge(test_graph_ix, after_for_stmt, EdgeType::Normal); self.cfg.add_edge(after_test_graph_ix, after_for_stmt, EdgeType::Normal);
self.cfg.after_statement( self.cfg.after_statement(
&statement_state, &statement_state,