dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter/react): rules_of_hooks resolve false positives with conditional hooks. (#3299)

Browse source 
related to #3071
This commit is contained in:
rzvxa 2024-05-16 16:16:52 +00:00
parent 7f9d8b71ee
commit c8f1f79d27
1 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
crates/oxc_linter/src/rules/react/rules_of_hooks.rs
View file

@ -278,9 +278,13 @@ impl RulesOfHooks {
) -> bool {
let graph = &ctx.semantic().cfg().graph;
// All nodes should be reachable from our hook, Otherwise we have a conditional/branching flow.
petgraph::algo::dijkstra(graph, func_cfg_ix, Some(node_cfg_ix), |_| 0)
.into_iter()
.any(|(f, _)| !petgraph::algo::has_path_connecting(graph, f, node_cfg_ix, None))
petgraph::algo::dijkstra(graph, func_cfg_ix, Some(node_cfg_ix), |e| match e.weight() {
EdgeType::NewFunction => 1,
EdgeType::Backedge | EdgeType::Normal => 0,
})
.into_iter()
.filter(|(_, val)| *val == 0)
.any(|(f, _)| !petgraph::algo::has_path_connecting(graph, f, node_cfg_ix, None))
}
#[inline(always)]
@ -874,6 +878,16 @@ fn test() {
return <div>test</div>;
};
",
"
function useLabeledBlock() {
let x = () => {
if (some) {
noop();
}
};
useHook();
}
",
];
let fail = vec![