dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter/unicorn): add fixer to throw-new-error (#5275)

Browse source 
got merged into the wrong branch (https://github.com/oxc-project/oxc/pull/5148), hence setting to merge when ready (as was already approved)
This commit is contained in:
camc314 2024-08-27 20:51:35 +00:00
parent 681bd8071a
commit c8e85323cb
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
crates/oxc_linter/src/rules/unicorn/throw_new_error.rs
View file

@ -48,7 +48,7 @@ declare_oxc_lint!(
/// ```
ThrowNewError,
style,
pending
fix
);
impl Rule for ThrowNewError {
@ -85,7 +85,9 @@ impl Rule for ThrowNewError {
_ => return,
}
ctx.diagnostic(throw_new_error_diagnostic(call_expr.span));
ctx.diagnostic_with_fix(throw_new_error_diagnostic(call_expr.span), |fixer| {
fixer.insert_text_before_range(call_expr.span, "new ")
});
}
}
@ -143,5 +145,10 @@ fn test() {
("throw (( getGlobalThis().Error ))()", None),
];
Tester::new(ThrowNewError::NAME, pass, fail).test_and_snapshot();
let fix = vec![
("throw Error()", "throw new Error()"),
("throw (( getGlobalThis().Error ))()", "throw new (( getGlobalThis().Error ))()"),
];
Tester::new(ThrowNewError::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
}