dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter/tree-shaking): align JSXMemberExpression's report (#5548)

Browse source 
Follow up #5450.

[eslint-plugin-tree-shaking](463fa1f0be/src/rules/no-side-effects-in-initialization.ts (L673-L677)) just report on `JSXMemberExpression.property`

![CleanShot 2024-09-06 at 22 34 55@2x](https://github.com/user-attachments/assets/a8dbfe43-daf8-4b96-b812-8afff5939b34)
This commit is contained in:
mysteryven 2024-09-06 14:43:39 +00:00
parent 14ee086182
commit c8ab353a68
2 changed files with 9 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
crates/oxc_linter/src/rules/tree_shaking/no_side_effects_in_initialization/listener_map.rs
View file

@ -7,11 +7,11 @@ use oxc_ast::{
ConditionalExpression, Declaration, ExportSpecifier, Expression, ForStatementInit,
FormalParameter, Function, IdentifierReference, JSXAttribute, JSXAttributeItem,
JSXAttributeValue, JSXChild, JSXElement, JSXElementName, JSXExpression,
JSXExpressionContainer, JSXFragment, JSXMemberExpression, JSXMemberExpressionObject,
JSXOpeningElement, LogicalExpression, MemberExpression, ModuleExportName, NewExpression,
ObjectExpression, ObjectPropertyKind, ParenthesizedExpression, PrivateFieldExpression,
Program, PropertyKey, SequenceExpression, SimpleAssignmentTarget, Statement,
StaticMemberExpression, SwitchCase, ThisExpression, UnaryExpression, VariableDeclarator,
JSXExpressionContainer, JSXFragment, JSXMemberExpression, JSXOpeningElement,
LogicalExpression, MemberExpression, ModuleExportName, NewExpression, ObjectExpression,
ObjectPropertyKind, ParenthesizedExpression, PrivateFieldExpression, Program, PropertyKey,
SequenceExpression, SimpleAssignmentTarget, Statement, StaticMemberExpression, SwitchCase,
ThisExpression, UnaryExpression, VariableDeclarator,
},
AstKind,
};
@ -799,17 +799,7 @@ impl<'a> ListenerMap for JSXElementName<'a> {
impl<'a> ListenerMap for JSXMemberExpression<'a> {
fn report_effects_when_called(&self, options: &NodeListenerOptions) {
self.object.report_effects_when_called(options);
}
}
impl<'a> ListenerMap for JSXMemberExpressionObject<'a> {
fn report_effects_when_called(&self, options: &NodeListenerOptions) {
match self {
Self::IdentifierReference(ident) => ident.report_effects_when_called(options),
Self::MemberExpression(member) => member.report_effects_when_called(options),
Self::ThisExpression(expr) => expr.report_effects_when_called(options),
}
options.ctx.diagnostic(super::call_member(self.property.span()));
}
}

6
crates/oxc_linter/src/snapshots/no_side_effects_in_initialization.snap
View file

@ -825,10 +825,10 @@ source: crates/oxc_linter/src/tester.rs
· ───
╰────
⚠ eslint-plugin-tree-shaking(no-side-effects-in-initialization): Cannot determine side-effects of calling
╭─[no_side_effects_in_initialization.tsx:1:11]
⚠ eslint-plugin-tree-shaking(no-side-effects-in-initialization): Cannot determine side-effects of calling member function
╭─[no_side_effects_in_initialization.tsx:1:34]
1 │ const X = {Y: ext}; const x = <X.Y />
· ────────
· ─
╰────
⚠ eslint-plugin-tree-shaking(no-side-effects-in-initialization): Cannot determine side-effects of calling global function `ext`