dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(ast): box PropertyKey enum

Browse source
This commit is contained in:
Boshen 2023-02-21 11:39:39 +08:00
parent cf278a2760
commit c640b4fb08
4 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_ast/src/ast/js.rs
View file

@ -258,8 +258,8 @@ pub struct Property<'a> {
#[derive(Debug, Serialize, PartialEq, Hash)]
#[serde(untagged)]
pub enum PropertyKey<'a> {
Identifier(IdentifierName),
PrivateIdentifier(PrivateIdentifier),
Identifier(Box<'a, IdentifierName>),
PrivateIdentifier(Box<'a, PrivateIdentifier>),
Expression(Expression<'a>),
}

2
crates/oxc_parser/src/js/class.rs
View file

@ -309,7 +309,7 @@ impl<'a> Parser<'a> {
match self.cur_kind() {
Kind::PrivateIdentifier => {
let private_ident = self.parse_private_identifier();
Ok((PropertyKey::PrivateIdentifier(private_ident), false))
Ok((PropertyKey::PrivateIdentifier(self.ast.alloc(private_ident)), false))
}
_ => self.parse_property_name(),
}

2
crates/oxc_parser/src/js/grammar.rs
View file

@ -150,7 +150,7 @@ impl<'a> CoverGrammar<'a, Property<'a>> for AssignmentTargetProperty<'a> {
if property.shorthand {
let binding = match property.key {
PropertyKey::Identifier(ident) => {
IdentifierReference { node: ident.node, name: ident.name }
IdentifierReference { node: ident.node, name: ident.unbox().name }
}
_ => return p.unexpected(),
};

12
crates/oxc_parser/src/js/object.rs
View file

@ -120,10 +120,9 @@ impl<'a> Parser<'a> {
Ok(self.ast.property(
self.end_node(node),
PropertyKind::Init,
PropertyKey::Identifier(IdentifierName {
node: identifier.node,
name: identifier.name,
}),
PropertyKey::Identifier(
self.ast.alloc(IdentifierName { node: identifier.node, name: identifier.name }),
),
PropertyValue::Expression(value),
/* method */ false,
/* shorthand */ true,
@ -167,7 +166,10 @@ impl<'a> Parser<'a> {
computed = true;
self.parse_computed_property_name().map(PropertyKey::Expression)?
}
_ => PropertyKey::Identifier(self.parse_identifier_name()?),
_ => {
let ident = self.parse_identifier_name()?;
PropertyKey::Identifier(self.ast.alloc(ident))
}
};
Ok((key, computed))
}