dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore(linter): remove the implementation from constructor_super

Browse source 
This should be implemented by a CFG
This commit is contained in:
Boshen 2023-12-25 15:21:37 +08:00
parent 868c35451d
commit c59508675d
No known key found for this signature in database
GPG key ID: 234DA6A7079C6801
2 changed files with 6 additions and 115 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

80
crates/oxc_linter/src/rules/eslint/constructor_super.rs
View file

@ -1,7 +1,3 @@
use oxc_ast::{
ast::{Expression, MethodDefinitionKind, Statement},
AstKind,
};
use oxc_diagnostics::{
miette::{self, Diagnostic},
thiserror::Error,
@ -46,71 +42,7 @@ declare_oxc_lint!(
);
impl Rule for ConstructorSuper {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
let AstKind::MethodDefinition(ctor) = node.kind() else { return };
if ctor.kind != MethodDefinitionKind::Constructor || ctor.value.body.is_none() {
return;
}
let Some(AstKind::Class(class)) =
ctx.nodes().parent_id(node.id()).and_then(|id| ctx.nodes().parent_kind(id))
else {
return;
};
// In cases where there's no super-class, calling 'super()' inside the constructor
// is handled by the parser.
if let Some(super_class) = &class.super_class {
ctor.value.body.as_ref().map_or_else(
|| {
ctx.diagnostic(ConstructorSuperDiagnostic(ctor.span));
},
|function_body| {
function_body
.statements
.iter()
.find_map(|stmt| {
let Statement::ExpressionStatement(expr) = stmt else { return None };
let Expression::CallExpression(call_expr) = &expr.expression else {
return None;
};
if matches!(call_expr.callee, Expression::Super(_)) {
Some(call_expr.span)
} else {
None
}
})
.map_or_else(
|| {
ctx.diagnostic(ConstructorSuperDiagnostic(ctor.span));
},
|span| {
if let Some(super_class_span) = super_class.span() {
ctx.diagnostic(SuperNotConstructorDiagnostic(
span,
super_class_span,
));
}
},
);
},
);
}
}
}
trait NonConstructor {
fn span(&self) -> Option<Span>;
}
impl<'a> NonConstructor for Expression<'a> {
fn span(&self) -> Option<Span> {
match self {
Self::NullLiteral(lit) => Some(lit.span),
Self::NumberLiteral(lit) => Some(lit.span),
Self::StringLiteral(lit) => Some(lit.span),
_ => None,
}
}
fn run<'a>(&self, _node: &AstNode<'a>, _ctx: &LintContext<'a>) {}
}
#[test]
@ -136,11 +68,11 @@ fn test() {
];
let fail = vec![
("class A extends B { constructor() {} }", None),
("class A extends null { constructor() { super(); } }", None),
("class A extends null { constructor() { } }", None),
("class A extends 100 { constructor() { super(); } }", None),
("class A extends 'test' { constructor() { super(); } }", None),
// ("class A extends B { constructor() {} }", None),
// ("class A extends null { constructor() { super(); } }", None),
// ("class A extends null { constructor() { } }", None),
// ("class A extends 100 { constructor() { super(); } }", None),
// ("class A extends 'test' { constructor() { super(); } }", None),
];
Tester::new(ConstructorSuper::NAME, pass, fail).test_and_snapshot();

41
crates/oxc_linter/src/snapshots/constructor_super.snap
View file

@ -2,45 +2,4 @@
source: crates/oxc_linter/src/tester.rs
expression: constructor_super
---
⚠ eslint(constructor-super): Expected to call 'super()'.
╭─[constructor_super.tsx:1:1]
1 │ class A extends B { constructor() {} }
· ────────────────
╰────
help: Ensure 'super()' is called from constructor
⚠ eslint(constructor-super): Unexpected 'super()' because 'super' is not a constructor.
╭─[constructor_super.tsx:1:1]
1 │ class A extends null { constructor() { super(); } }
· ──┬─ ───┬───
· │ ╰── unexpected 'super()'
· ╰── because this is not a constructor
╰────
help: Do not call 'super()' from constructor.
⚠ eslint(constructor-super): Expected to call 'super()'.
╭─[constructor_super.tsx:1:1]
1 │ class A extends null { constructor() { } }
· ─────────────────
╰────
help: Ensure 'super()' is called from constructor
⚠ eslint(constructor-super): Unexpected 'super()' because 'super' is not a constructor.
╭─[constructor_super.tsx:1:1]
1 │ class A extends 100 { constructor() { super(); } }
· ─┬─ ───┬───
· │ ╰── unexpected 'super()'
· ╰── because this is not a constructor
╰────
help: Do not call 'super()' from constructor.
⚠ eslint(constructor-super): Unexpected 'super()' because 'super' is not a constructor.
╭─[constructor_super.tsx:1:1]
1 │ class A extends 'test' { constructor() { super(); } }
· ───┬── ───┬───
· │ ╰── unexpected 'super()'
· ╰── because this is not a constructor
╰────
help: Do not call 'super()' from constructor.