dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter/import): false positive for indirect export in namespace (#2862)

Browse source
This commit is contained in:
Dunqing 2024-03-30 12:55:51 +08:00 committed by GitHub
parent 23651980d1
commit c4528974cb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_linter/fixtures/import/oxc/indirect-export.js Normal file
View file

@ -0,0 +1,2 @@
import { a } from '../named-exports'
export { a }

9
crates/oxc_linter/src/rules/import/namespace.rs
View file

@ -198,7 +198,13 @@ fn get_module_request_name(name: &str, module_record: &ModuleRecord) -> Option<S
false false
} }
ExportImportName::Name(name_span) => name_span.name().as_str() == name, ExportImportName::Name(name_span) => {
return name_span.name().as_str() == name
&& module_record.import_entries.iter().any(|entry| {
entry.local_name.name().as_str() == name
&& entry.import_name.is_namespace_object()
})
}
_ => false, _ => false,
}) })
{ {
@ -443,6 +449,7 @@ fn test() {
(r#"import * as a from "./deep-es7/a"; console.log(a.b.c.d.e.f)"#, None), (r#"import * as a from "./deep-es7/a"; console.log(a.b.c.d.e.f)"#, None),
(r#"import * as a from "./deep-es7/a"; var {b:{c:{d:{e}}}} = a"#, None), (r#"import * as a from "./deep-es7/a"; var {b:{c:{d:{e}}}} = a"#, None),
(r#"import { b } from "./deep-es7/a"; var {c:{d:{e}}} = b"#, None), (r#"import { b } from "./deep-es7/a"; var {c:{d:{e}}} = b"#, None),
(r"import { a } from './oxc/indirect-export'; console.log(a.nothing)", None),
]; ];
let fail = vec![ let fail = vec![