dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 20:28:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(transformer): add to SymbolTable::declarations for all symbols (#4460)

Browse source 
`declarations` field of `SymbolTable` is part of the SoA group field. For it to be valid to index into with `SymbolId`, an entry must be added for every new symbol which is created.
This commit is contained in:
overlookmotel 2024-07-26 00:14:29 +00:00
parent a49f4915de
commit c04b9aa5db
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_transformer/src/typescript/enum.rs
View file

@ -4,6 +4,7 @@ use oxc_allocator::Vec;
use oxc_ast::{ast::*, visit::walk_mut, VisitMut};
use oxc_span::{Atom, Span, SPAN};
use oxc_syntax::{
node::AstNodeId,
number::{NumberBase, ToJsInt32, ToJsString},
operator::{AssignmentOperator, BinaryOperator, LogicalOperator, UnaryOperator},
reference::ReferenceFlag,
@ -80,6 +81,7 @@ impl<'a> TypeScriptEnum<'a> {
SymbolFlags::FunctionScopedVariable,
func_scope_id,
);
ctx.symbols_mut().add_declaration(AstNodeId::DUMMY);
let ident = BindingIdentifier {
span: decl.id.span,
name: decl.id.name.clone(),

1
crates/oxc_traverse/src/context/scoping.rs
View file

@ -246,6 +246,7 @@ impl TraverseScoping {
// Add binding to scope
let symbol_id = self.symbols.create_symbol(SPAN, name.clone(), flags, scope_id);
self.symbols.add_declaration(AstNodeId::DUMMY);
self.scopes.add_binding(scope_id, name, symbol_id);
symbol_id
}