dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(codegen): print JSXAttributeValue::StringLiteral directly (#4231)

Browse source 
jsx attribute string is interpreted as is without escaping.

The transformer is responsible for converting it to plain js string.
This commit is contained in:
Boshen 2024-07-12 16:17:23 +00:00
parent 6fb808febf
commit be82c286d6
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_codegen/src/gen.rs
View file

@ -2239,7 +2239,7 @@ impl<'a, const MINIFY: bool> Gen<MINIFY> for JSXAttributeValue<'a> {
Self::Element(el) => el.gen(p, ctx),
Self::StringLiteral(lit) => {
p.print_char(b'"');
print_unquoted_str(&lit.value, b'"', p);
p.print_str(&lit.value);
p.print_char(b'"');
}
Self::ExpressionContainer(expr_container) => expr_container.gen(p, ctx),

4
tasks/coverage/codegen_typescript.snap
View file

@ -2,7 +2,5 @@ commit: d8086f14
codegen_typescript Summary:
AST Parsed : 5283/5283 (100.00%)
Positive Passed: 5280/5283 (99.94%)
Normal failed: "compiler/jsxMultilineAttributeStringValues.tsx"
Normal failed: "compiler/jsxMultilineAttributeValuesReact.tsx"
Positive Passed: 5282/5283 (99.98%)
Normal failed: "conformance/jsx/tsxReactEmitEntities.tsx"