diff --git a/crates/oxc_ast/src/ast/js.rs b/crates/oxc_ast/src/ast/js.rs index bfc187b8c..425f42890 100644 --- a/crates/oxc_ast/src/ast/js.rs +++ b/crates/oxc_ast/src/ast/js.rs @@ -1113,7 +1113,7 @@ impl VariableDeclarationKind { matches!(self, Self::Const | Self::Let) } - pub fn to_string(&self) -> &str { + pub fn as_str(&self) -> &'static str { match self { Self::Var => "var", Self::Const => "const", @@ -1124,7 +1124,7 @@ impl VariableDeclarationKind { impl fmt::Display for VariableDeclarationKind { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - let s = self.to_string(); + let s = self.as_str(); write!(f, "{s}") } } diff --git a/crates/oxc_prettier/src/format.rs b/crates/oxc_prettier/src/format.rs index d3f549dee..4b1cb3f07 100644 --- a/crates/oxc_prettier/src/format.rs +++ b/crates/oxc_prettier/src/format.rs @@ -353,12 +353,12 @@ impl<'a> Format<'a> for Declaration<'a> { impl<'a> Format<'a> for VariableDeclaration<'a> { fn format(&self, p: &mut Prettier<'a>) -> Doc<'a> { - let kind = self.kind.to_string(); + let kind = self.kind.as_str(); let mut decls = p.vec(); decls.extend(self.declarations.iter().map(|decl| decl.format(p))); let mut parts = p.vec(); - parts.push(p.str(kind)); + parts.push(ss!(kind)); parts.push(ss!(" ")); parts.push(Doc::Array(decls)); diff --git a/crates/oxc_semantic/src/checker/javascript.rs b/crates/oxc_semantic/src/checker/javascript.rs index c9ce4305b..78ef21dc1 100644 --- a/crates/oxc_semantic/src/checker/javascript.rs +++ b/crates/oxc_semantic/src/checker/javascript.rs @@ -216,8 +216,7 @@ fn check_binding_identifier<'a>( )] #[diagnostic()] struct InvalidLetDeclaration(String, #[label] Span); - return ctx - .error(InvalidLetDeclaration(decl.kind.to_string().into(), ident.span)); + return ctx.error(InvalidLetDeclaration(decl.kind.as_str().into(), ident.span)); } AstKind::VariableDeclaration(_) | AstKind::Function(_) | AstKind::Program(_) => { break;