dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): allow whitespace control characters in no-control-regex (#6140)

Browse source 
- fixes https://github.com/oxc-project/oxc/issues/6136

The original eslint rule checks if chars start with `\u` or `\x`, but our character spans are currently busted and only report 1 char for chars like `\u{0a}`. I've made whitespace an exception to the rule, so we don't report `\x0a` currently, which is fine for now I think
This commit is contained in:
camchenry 2024-09-28 12:45:27 +00:00
parent 14ba263506
commit be0030cdb8
1 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
crates/oxc_linter/src/rules/eslint/no_control_regex.rs
View file

@ -181,7 +181,15 @@ struct ControlCharacterFinder {
impl<'a> Visit<'a> for ControlCharacterFinder {
fn visit_character(&mut self, ch: &Character) {
// Control characters are in the range 0x00 to 0x1F
if ch.value <= 0x1F {
if ch.value <= 0x1F &&
// tab
ch.value != 0x09 &&
// line feed
ch.value != 0x0A &&
// carriage return
ch.value != 0x0D
{
// TODO: check if starts with \x or \u when char spans work correctly
self.control_chars.push(ch.to_string());
}
}
@ -279,6 +287,15 @@ mod tests {
r"new RegExp('\\u{1F}')",
r"new RegExp('\\u{1F}', 'g')",
r"new RegExp('\\u{1F}', flags)", // unknown flags, we assume no 'u'
// https://github.com/oxc-project/oxc/issues/6136
r"/---\n([\s\S]+?)\n---/",
r"/import \{((?:.|\n)*)\} from '@romejs\/js-ast';/",
r"/^\t+/",
r"/\n/g",
r"/\r\n|\r|\n/",
r"/[\n\r\p{Z}\p{P}]/u",
r"/[\n\t]+/g",
r"/^expected `string`\.\n {2}in Foo \(at (.*)[/\\]debug[/\\]test[/\\]browser[/\\]debug\.test\.js:[0-9]+\)$/",
],
vec![
r"var regex = /\x1f/",
@ -296,6 +313,14 @@ mod tests {
r"/\u{1F}/ugi",
r"new RegExp('\\u{1F}', 'u')",
r"new RegExp('\\u{1F}', 'ugi')",
// https://github.com/oxc-project/oxc/issues/6136
// TODO: uncomment when char spans work correctly
// r"/\u{0a}/u",
// r"/\x0a/u",
// r"/\u{0d}/u",
// r"/\x0d/u",
// r"/\u{09}/u",
// r"/\x09/u",
],
)
.test_and_snapshot();