dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): handle user variables correctly for import/no_commonjs (#7316)

Browse source 
test case found in `typescript/no-require-imports`
This commit is contained in:
Dmitry Zakharov 2024-11-19 04:23:16 +03:00 committed by GitHub
parent 1d9f528668
commit bc0e72c1e2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
crates/oxc_linter/src/rules/import/no_commonjs.rs
View file

@ -10,7 +10,6 @@ use oxc_ast::{
use crate::{context::LintContext, rule::Rule, AstNode};
fn no_commonjs_diagnostic(span: Span, name: &str, actual: &str) -> OxcDiagnostic {
// See <https://oxc.rs/docs/contribute/linter/adding-rules.html#diagnostics> for details
OxcDiagnostic::warn(format!("Expected {name} instead of {actual}"))
.with_help("Do not use CommonJS `require` calls and `module.exports` or `exports.*`")
.with_label(span)
@ -214,6 +213,10 @@ impl Rule for NoCommonjs {
return;
}
if ctx.scopes().find_binding(ctx.scopes().root_scope_id(), "require").is_some() {
return;
}
if let Argument::TemplateLiteral(template_literal) = &call_expr.arguments[0] {
if template_literal.expressions.len() != 0 {
return;
@ -299,6 +302,15 @@ fn test() {
Some(json!([{ "allowRequire": false }])),
),
(r#"try { require("x") } catch (error) {}"#, None),
// covers user variables
(
"
import { createRequire } from 'module';
const require = createRequire();
require('remark-preset-prettier');
",
None,
),
];
let fail = vec![