dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter/react): Fixed false positive with missing key inside React.Children.toArray() for fragments (#5133)

Browse source 
Related: #4421 and #4945
This commit is contained in:
Earl Chase 2024-08-24 03:01:50 -05:00 committed by GitHub
parent c96609151e
commit ba62a71975
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
crates/oxc_linter/src/rules/react/jsx_key.rs
View file

@ -269,6 +269,9 @@ fn check_jsx_element_is_key_before_spread<'a>(jsx_elem: &JSXElement<'a>, ctx: &L
fn check_jsx_fragment<'a>(node: &AstNode<'a>, fragment: &JSXFragment<'a>, ctx: &LintContext<'a>) {
if let Some(outer) = is_in_array_or_iter(node, ctx) {
if is_within_children_to_array(node, ctx) {
return;
}
ctx.diagnostic(gen_diagnostic(fragment.opening_fragment.span, &outer));
}
}
@ -487,6 +490,14 @@ fn test() {
React.Children.toArray([1, 2 ,3].map(x => <App />));
"#,
r"React.Children.toArray([1, 2 ,3].map(x => <App />));",
r"{React.Children.toArray(items.map((item) => {
return (
<>
{item}
</>
);
}))}
",
];
let fail = vec![