dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(editors/vscode): temporarily solve oxc_language_server issue on windows (#6384)

Browse source 
closes #6382 

It seems we cannot support `oxc_language_server` by directly reusing
code from `coc-oxc`, at least not on Windows, because it requires an
`.exe` executable.

I will take some time to study the implementation of `Biome` to enhance
our vscode plugin.
This commit is contained in:
dalaoshu 2024-10-09 20:52:54 +08:00 committed by GitHub
parent eacde0553e
commit b9c94bbc44
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
editors/vscode/client/extension.ts
View file

@ -104,7 +104,9 @@ export async function activate(context: ExtensionContext) {
} }
const workspaceFolders = workspace.workspaceFolders; const workspaceFolders = workspace.workspaceFolders;
if (workspaceFolders) { const isWindows = process.platform === 'win32';
if (workspaceFolders?.length && !isWindows) {
try { try {
return await Promise.any( return await Promise.any(
workspaceFolders.map(async (folder) => { workspaceFolders.map(async (folder) => {
@ -122,7 +124,7 @@ export async function activate(context: ExtensionContext) {
} catch {} } catch {}
} }
const ext = process.platform === 'win32' ? '.exe' : ''; const ext = isWindows ? '.exe' : '';
// NOTE: The `./target/release` path is aligned with the path defined in .github/workflows/release_vscode.yml // NOTE: The `./target/release` path is aligned with the path defined in .github/workflows/release_vscode.yml
return ( return (
process.env.SERVER_PATH_DEV ?? process.env.SERVER_PATH_DEV ??