From b9322c68e6d03929bd7462bdda45853904be8fc3 Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Sat, 14 Dec 2024 14:48:27 +0000 Subject: [PATCH] feat(semantic): re-export all flags and ID types (#7886) `oxc_semantic` already re-exports `ScopeId`, `ScopeFlags`, `SymbolId` and `SymbolFlags` from `oxc_syntax`. It seems inconsistent that it doesn't also re-export `ReferenceId`, `ReferenceFlags`, `NodeId` and `NodeFlags` too. Do that. --- crates/oxc_semantic/src/lib.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/oxc_semantic/src/lib.rs b/crates/oxc_semantic/src/lib.rs index 591d76223..d0050f568 100644 --- a/crates/oxc_semantic/src/lib.rs +++ b/crates/oxc_semantic/src/lib.rs @@ -12,7 +12,10 @@ use oxc_ast::{ }; use oxc_cfg::ControlFlowGraph; use oxc_span::{GetSpan, SourceType, Span}; +// Re-export flags and ID types pub use oxc_syntax::{ + node::{NodeFlags, NodeId}, + reference::{ReferenceFlags, ReferenceId}, scope::{ScopeFlags, ScopeId}, symbol::{SymbolFlags, SymbolId}, }; @@ -38,8 +41,8 @@ use class::ClassTable; pub use crate::{ builder::{SemanticBuilder, SemanticBuilderReturn}, jsdoc::{JSDoc, JSDocFinder, JSDocTag}, - node::{AstNode, AstNodes, NodeId}, - reference::{Reference, ReferenceFlags, ReferenceId}, + node::{AstNode, AstNodes}, + reference::Reference, scope::ScopeTree, stats::Stats, symbol::{IsGlobalReference, SymbolTable},