dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer): shorten code (#6809)

Browse source 
Use `BoundIdentifier::create_binding_pattern`, rather than writing out the code to create a `BindingPattern` manually each time.
This commit is contained in:
overlookmotel 2024-10-23 13:18:09 +00:00
parent e59b5d919d
commit b8dfa191be
3 changed files with 10 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_transformer/src/common/var_declarations.rs
View file

@ -15,7 +15,7 @@
use std::cell::RefCell; use std::cell::RefCell;
use oxc_allocator::Vec; use oxc_allocator::Vec;
use oxc_ast::{ast::*, NONE}; use oxc_ast::ast::*;
use oxc_data_structures::stack::SparseStack; use oxc_data_structures::stack::SparseStack;
use oxc_span::SPAN; use oxc_span::SPAN;
use oxc_traverse::{Ancestor, BoundIdentifier, Traverse, TraverseCtx}; use oxc_traverse::{Ancestor, BoundIdentifier, Traverse, TraverseCtx};
@ -74,10 +74,8 @@ impl<'a> VarDeclarationsStore<'a> {
init: Option<Expression<'a>>, init: Option<Expression<'a>>,
ctx: &TraverseCtx<'a>, ctx: &TraverseCtx<'a>,
) { ) {
let ident = binding.create_binding_identifier(ctx); let pattern = binding.create_binding_pattern(ctx);
let ident = ctx.ast.binding_pattern_kind_from_binding_identifier(ident); self.insert_binding_pattern(pattern, init, ctx);
let ident = ctx.ast.binding_pattern(ident, NONE, false);
self.insert_binding_pattern(ident, init, ctx);
} }
/// Add a `VariableDeclarator` to be inserted at top of current enclosing statement block, /// Add a `VariableDeclarator` to be inserted at top of current enclosing statement block,

12
crates/oxc_transformer/src/es2015/arrow_functions.rs
View file

@ -127,7 +127,7 @@
use serde::Deserialize; use serde::Deserialize;
use oxc_allocator::Vec; use oxc_allocator::Vec;
use oxc_ast::{ast::*, NONE}; use oxc_ast::ast::*;
use oxc_data_structures::stack::SparseStack; use oxc_data_structures::stack::SparseStack;
use oxc_span::SPAN; use oxc_span::SPAN;
use oxc_syntax::{ use oxc_syntax::{
@ -409,18 +409,10 @@ impl<'a> ArrowFunctions<'a> {
this_var: &BoundIdentifier<'a>, this_var: &BoundIdentifier<'a>,
ctx: &TraverseCtx<'a>, ctx: &TraverseCtx<'a>,
) { ) {
let binding_pattern = ctx.ast.binding_pattern(
ctx.ast.binding_pattern_kind_from_binding_identifier(
this_var.create_binding_identifier(ctx),
),
NONE,
false,
);
let variable_declarator = ctx.ast.variable_declarator( let variable_declarator = ctx.ast.variable_declarator(
SPAN, SPAN,
VariableDeclarationKind::Var, VariableDeclarationKind::Var,
binding_pattern, this_var.create_binding_pattern(ctx),
Some(ctx.ast.expression_this(SPAN)), Some(ctx.ast.expression_this(SPAN)),
false, false,
); );

17
crates/oxc_transformer/src/react/jsx_source.rs
View file

@ -35,7 +35,7 @@
use ropey::Rope; use ropey::Rope;
use oxc_ast::{ast::*, NONE}; use oxc_ast::ast::*;
use oxc_diagnostics::OxcDiagnostic; use oxc_diagnostics::OxcDiagnostic;
use oxc_span::{Span, SPAN}; use oxc_span::{Span, SPAN};
use oxc_syntax::{number::NumberBase, symbol::SymbolFlags}; use oxc_syntax::{number::NumberBase, symbol::SymbolFlags};
@ -205,17 +205,10 @@ impl<'a, 'ctx> ReactJsxSource<'a, 'ctx> {
) -> Option<VariableDeclarator<'a>> { ) -> Option<VariableDeclarator<'a>> {
let filename_var = self.filename_var.as_ref()?; let filename_var = self.filename_var.as_ref()?;
let var_kind = VariableDeclarationKind::Var; let id = filename_var.create_binding_pattern(ctx);
let id = { let init = ctx.ast.expression_string_literal(SPAN, self.ctx.source_path.to_string_lossy());
let ident = filename_var.create_binding_identifier(ctx); let decl =
let ident = ctx.ast.binding_pattern_kind_from_binding_identifier(ident); ctx.ast.variable_declarator(SPAN, VariableDeclarationKind::Var, id, Some(init), false);
ctx.ast.binding_pattern(ident, NONE, false)
};
let decl = {
let init =
ctx.ast.expression_string_literal(SPAN, self.ctx.source_path.to_string_lossy());
ctx.ast.variable_declarator(SPAN, var_kind, id, Some(init), false)
};
Some(decl) Some(decl)
} }