dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(semantic): rename vars in transform checker (#5072)

Browse source 
Pure refactor. Just rename some vars for consistency.
This commit is contained in:
overlookmotel 2024-08-22 13:41:35 +00:00
parent 6d87b0f1f2
commit b8c6ce5317
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
crates/oxc_semantic/src/post_transform_checker.rs
View file

@ -317,18 +317,18 @@ impl<'s> PostTransformChecker<'s> {
.map(Pair::from_tuple) .map(Pair::from_tuple)
{ {
// Check bindings are the same // Check bindings are the same
fn get_sorted_bindings(data: &SemanticData, scope_id: ScopeId) -> Vec<CompactStr> { fn get_sorted_binding_names(data: &SemanticData, scope_id: ScopeId) -> Vec<CompactStr> {
let mut bindings = let mut binding_names =
data.scopes.get_bindings(scope_id).keys().cloned().collect::<Vec<_>>(); data.scopes.get_bindings(scope_id).keys().cloned().collect::<Vec<_>>();
bindings.sort_unstable(); binding_names.sort_unstable();
bindings binding_names
} }
let scope_ids = match scope_ids.into_parts() { let scope_ids = match scope_ids.into_parts() {
(None, None) => continue, (None, None) => continue,
(Some(scope_id_after_transform), Some(scope_id_rebuilt)) => { (Some(scope_id_after_transform), Some(scope_id_rebuilt)) => {
let scope_ids = Pair::new(scope_id_after_transform, scope_id_rebuilt); let scope_ids = Pair::new(scope_id_after_transform, scope_id_rebuilt);
let binding_names = self.get_pair(scope_ids, get_sorted_bindings); let binding_names = self.get_pair(scope_ids, get_sorted_binding_names);
if binding_names.is_mismatch() { if binding_names.is_mismatch() {
self.errors.push_mismatch("Bindings mismatch", scope_ids, binding_names); self.errors.push_mismatch("Bindings mismatch", scope_ids, binding_names);
} else { } else {
@ -361,18 +361,18 @@ impl<'s> PostTransformChecker<'s> {
scope_ids scope_ids
} }
(Some(scope_id), None) => { (Some(scope_id), None) => {
let bindings = get_sorted_bindings(&self.after_transform, scope_id); let binding_names = get_sorted_binding_names(&self.after_transform, scope_id);
self.errors.push_mismatch_strs( self.errors.push_mismatch_strs(
"Bindings mismatch", "Bindings mismatch",
Pair::new(format!("{scope_id:?}: {bindings:?}").as_str(), "No scope"), Pair::new(format!("{scope_id:?}: {binding_names:?}").as_str(), "No scope"),
); );
continue; continue;
} }
(None, Some(scope_id)) => { (None, Some(scope_id)) => {
let bindings = get_sorted_bindings(&self.rebuilt, scope_id); let binding_names = get_sorted_binding_names(&self.rebuilt, scope_id);
self.errors.push_mismatch_strs( self.errors.push_mismatch_strs(
"Bindings mismatch", "Bindings mismatch",
Pair::new("No scope", format!("{scope_id:?}: {bindings:?}").as_str()), Pair::new("No scope", format!("{scope_id:?}: {binding_names:?}").as_str()),
); );
continue; continue;
} }