dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(ast_codegen): no longer outputs discard variable for empty visitors. (#4008)

Browse source
This commit is contained in:
rzvxa 2024-07-02 10:18:53 +00:00
parent cd1e9bde7f
commit b51f75baf8
3 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crates/oxc_ast/src/generated/visit.rs
View file

@ -1574,7 +1574,6 @@ pub mod walk {
pub fn walk_template_element<'a, V: Visit<'a>>(visitor: &mut V, it: &TemplateElement<'a>) { pub fn walk_template_element<'a, V: Visit<'a>>(visitor: &mut V, it: &TemplateElement<'a>) {
// NOTE: AstKind doesn't exists! // NOTE: AstKind doesn't exists!
let _ = (visitor, it);
} }
pub fn walk_expressions<'a, V: Visit<'a>>(visitor: &mut V, it: &Vec<'a, Expression<'a>>) { pub fn walk_expressions<'a, V: Visit<'a>>(visitor: &mut V, it: &Vec<'a, Expression<'a>>) {
@ -2480,7 +2479,6 @@ pub mod walk {
pub fn walk_js_doc_unknown_type<'a, V: Visit<'a>>(visitor: &mut V, it: &JSDocUnknownType) { pub fn walk_js_doc_unknown_type<'a, V: Visit<'a>>(visitor: &mut V, it: &JSDocUnknownType) {
// NOTE: AstKind doesn't exists! // NOTE: AstKind doesn't exists!
let _ = (visitor, it);
} }
pub fn walk_decorators<'a, V: Visit<'a>>(visitor: &mut V, it: &Vec<'a, Decorator<'a>>) { pub fn walk_decorators<'a, V: Visit<'a>>(visitor: &mut V, it: &Vec<'a, Decorator<'a>>) {
@ -3217,7 +3215,6 @@ pub mod walk {
pub fn walk_jsx_empty_expression<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXEmptyExpression) { pub fn walk_jsx_empty_expression<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXEmptyExpression) {
// NOTE: AstKind doesn't exists! // NOTE: AstKind doesn't exists!
let _ = (visitor, it);
} }
pub fn walk_jsx_fragment<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXFragment<'a>) { pub fn walk_jsx_fragment<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXFragment<'a>) {

3
crates/oxc_ast/src/generated/visit_mut.rs
View file

@ -1585,7 +1585,6 @@ pub mod walk_mut {
it: &mut TemplateElement<'a>, it: &mut TemplateElement<'a>,
) { ) {
// NOTE: AstType doesn't exists! // NOTE: AstType doesn't exists!
let _ = (visitor, it);
} }
pub fn walk_expressions<'a, V: VisitMut<'a>>( pub fn walk_expressions<'a, V: VisitMut<'a>>(
@ -2584,7 +2583,6 @@ pub mod walk_mut {
it: &mut JSDocUnknownType, it: &mut JSDocUnknownType,
) { ) {
// NOTE: AstType doesn't exists! // NOTE: AstType doesn't exists!
let _ = (visitor, it);
} }
pub fn walk_decorators<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Vec<'a, Decorator<'a>>) { pub fn walk_decorators<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Vec<'a, Decorator<'a>>) {
@ -3378,7 +3376,6 @@ pub mod walk_mut {
it: &mut JSXEmptyExpression, it: &mut JSXEmptyExpression,
) { ) {
// NOTE: AstType doesn't exists! // NOTE: AstType doesn't exists!
let _ = (visitor, it);
} }
pub fn walk_jsx_fragment<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut JSXFragment<'a>) { pub fn walk_jsx_fragment<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut JSXFragment<'a>) {

3
tasks/ast_codegen/src/generators/visit.rs
View file

@ -583,8 +583,6 @@ impl<'a> VisitBuilder<'a> {
.collect(); .collect();
let body = if KIND_BLACK_LIST.contains(&ident.to_string().as_str()) { let body = if KIND_BLACK_LIST.contains(&ident.to_string().as_str()) {
let unused =
if fields_visits.is_empty() { Some(quote!(let _ = (visitor, it);)) } else { None };
let note = insert!( let note = insert!(
"// NOTE: {} doesn't exists!", "// NOTE: {} doesn't exists!",
if self.is_mut { "AstType" } else { "AstKind" } if self.is_mut { "AstType" } else { "AstKind" }
@ -592,7 +590,6 @@ impl<'a> VisitBuilder<'a> {
quote! { quote! {
#note #note
#(#fields_visits)* #(#fields_visits)*
#unused
} }
} else { } else {
let kind = self.kind_type(ident); let kind = self.kind_type(ident);