dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(semantic): Stats store counts as u32 (#5754)

Browse source 
These counts can never exceed `u32`, so reduce size of these fields.
This commit is contained in:
overlookmotel 2024-09-13 12:19:54 +00:00
parent 667170cbfc
commit b4b460f425
2 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
crates/oxc_semantic/src/builder.rs
View file

@ -233,9 +233,9 @@ impl<'a> SemanticBuilder<'a> {
// TODO: It would be even more efficient to calculate counts in parser to avoid
// this extra AST traversal.
let stats = Stats::count(program);
self.nodes.reserve(stats.nodes);
self.scope.reserve(stats.scopes);
self.symbols.reserve(stats.symbols, stats.references);
self.nodes.reserve(stats.nodes as usize);
self.scope.reserve(stats.scopes as usize);
self.symbols.reserve(stats.symbols as usize, stats.references as usize);
// Visit AST to generate scopes tree etc
self.visit_program(program);
@ -243,11 +243,12 @@ impl<'a> SemanticBuilder<'a> {
// Check that estimated counts accurately
#[cfg(debug_assertions)]
{
#[allow(clippy::cast_possible_truncation)]
let actual_stats = Stats {
nodes: self.nodes.len(),
scopes: self.scope.len(),
symbols: self.symbols.len(),
references: self.symbols.references.len(),
nodes: self.nodes.len() as u32,
scopes: self.scope.len() as u32,
symbols: self.symbols.len() as u32,
references: self.symbols.references.len() as u32,
};
Stats::assert_accurate(&actual_stats, &stats);
}

8
crates/oxc_semantic/src/stats.rs
View file

@ -15,10 +15,10 @@ use oxc_syntax::scope::{ScopeFlags, ScopeId};
#[derive(Default, Debug)]
pub(crate) struct Stats {
pub nodes: usize,
pub scopes: usize,
pub symbols: usize,
pub references: usize,
pub nodes: u32,
pub scopes: u32,
pub symbols: u32,
pub references: u32,
}
impl Stats {