dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): no_global_assign rule: reduce name lookups (#6460)

Browse source 
2 small optimizations to this lint rule:

1. Get the name for the symbol only once, rather than on each turn of the inner loop (every reference to a symbol has the same name by definition).
2. Avoid creating temporary `CompactStr`s, which causes an allocation if the string is longer than 24 bytes.
This commit is contained in:
overlookmotel 2024-10-11 20:53:35 +00:00
parent 7645e5c34b
commit b48c3683d6
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
crates/oxc_linter/src/rules/eslint/no_global_assign.rs
View file

@ -59,19 +59,17 @@ impl Rule for NoGlobalAssign {
fn run_once(&self, ctx: &LintContext) { fn run_once(&self, ctx: &LintContext) {
let symbol_table = ctx.symbols(); let symbol_table = ctx.symbols();
for reference_id_list in ctx.scopes().root_unresolved_references_ids() { for (name, reference_id_list) in ctx.scopes().root_unresolved_references() {
for reference_id in reference_id_list { for &reference_id in reference_id_list {
let reference = symbol_table.get_reference(reference_id); let reference = symbol_table.get_reference(reference_id);
if reference.is_write() { if reference.is_write()
let name = ctx.semantic().reference_name(reference); && !self.excludes.contains(name)
if !self.excludes.contains(&CompactStr::from(name)) && ctx.env_contains_var(name)
&& ctx.env_contains_var(name) {
{ ctx.diagnostic(no_global_assign_diagnostic(
ctx.diagnostic(no_global_assign_diagnostic( name,
name, ctx.semantic().reference_span(reference),
ctx.semantic().reference_span(reference), ));
));
}
} }
} }
} }