dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter): add fixer for unicorn/no-length-as-slice-end (#4780)

Browse source 
part of #4179 

test:
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/test/snapshots/no-length-as-slice-end.mjs.md
This commit is contained in:
heygsc 2024-08-09 19:41:52 +08:00 committed by GitHub
parent 92777d0aae
commit b259f47007
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 25 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
crates/oxc_linter/src/rules/unicorn/no_length_as_slice_end.rs
View file

@ -1,7 +1,7 @@
use oxc_ast::{ast::MemberExpression, AstKind};
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::Span;
use oxc_span::{GetSpan, Span};
use crate::{
ast_util::is_method_call, context::LintContext, rule::Rule, utils::is_same_reference, AstNode,
@ -37,7 +37,8 @@ declare_oxc_lint!(
/// foo.slice(1)
/// ```
NoLengthAsSliceEnd,
restriction
restriction,
fix
);
impl Rule for NoLengthAsSliceEnd {
@ -76,10 +77,18 @@ impl Rule for NoLengthAsSliceEnd {
return;
}
ctx.diagnostic(no_length_as_slice_end_diagnostic(
call_expr.callee.get_member_expr().unwrap().static_property_info().unwrap().0,
second_argument.span,
));
ctx.diagnostic_with_fix(
no_length_as_slice_end_diagnostic(
call_expr.callee.get_member_expr().unwrap().static_property_info().unwrap().0,
second_argument.span,
),
|fixer| {
let start = call_expr.arguments[0].span().end;
let end = call_expr.arguments[1].span().end;
let span = Span::new(start, end);
fixer.delete(&span)
},
);
}
}
@ -115,5 +124,14 @@ fn test() {
"foo?.slice(1, foo?.length)",
];
Tester::new(NoLengthAsSliceEnd::NAME, pass, fail).test_and_snapshot();
let fix = vec![
("foo.slice(1, foo.length)", "foo.slice(1)"),
("foo?.slice(1, foo.length)", "foo?.slice(1)"),
("foo.slice(1, foo.length,)", "foo.slice(1,)"),
("foo.slice(1, (( foo.length )))", "foo.slice(1)"),
("foo.slice(1, foo?.length)", "foo.slice(1)"),
("foo?.slice(1, foo?.length)", "foo?.slice(1)"),
];
Tester::new(NoLengthAsSliceEnd::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
}