From b251c10b09778f363bba248eb1aa1ba0180ee9e7 Mon Sep 17 00:00:00 2001 From: Dunqing Date: Sat, 18 Nov 2023 13:37:55 +0800 Subject: [PATCH] feat(prettier): print parameters in ArrowExpression (#1400) --- crates/oxc_prettier/src/format/arrow_function.rs | 5 ++++- tasks/prettier_conformance/prettier.snap.md | 6 +----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/crates/oxc_prettier/src/format/arrow_function.rs b/crates/oxc_prettier/src/format/arrow_function.rs index e3c966b7b..c7d8b41d1 100644 --- a/crates/oxc_prettier/src/format/arrow_function.rs +++ b/crates/oxc_prettier/src/format/arrow_function.rs @@ -9,7 +9,10 @@ pub(super) fn print_arrow_function<'a>( ) -> Doc<'a> { let mut parts = p.vec(); - parts.push(ss!("() => ")); + let parameters = expr.params.format(p); + parts.push(parameters); + parts.push(ss!(" => ")); + if expr.expression { let stmt = &expr.body.statements[0]; match stmt { diff --git a/tasks/prettier_conformance/prettier.snap.md b/tasks/prettier_conformance/prettier.snap.md index ac886435e..9573b3494 100644 --- a/tasks/prettier_conformance/prettier.snap.md +++ b/tasks/prettier_conformance/prettier.snap.md @@ -1,4 +1,4 @@ -Compatibility: 90/881 (10.22%) +Compatibility: 92/881 (10.44%) # Failed @@ -180,7 +180,6 @@ Compatibility: 90/881 (10.22%) * break-calls/break.js * break-calls/parent.js * break-calls/react.js -* break-calls/reduce.js ### call/first-argument-expansion * call/first-argument-expansion/expression-2nd-arg.js @@ -440,9 +439,6 @@ Compatibility: 90/881 (10.22%) * do/call-arguments.js * do/do.js -### dynamic-import -* dynamic-import/test.js - ### empty-paren-comment * empty-paren-comment/class-property.js * empty-paren-comment/class.js