dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter): add fixer for eslint/no-eq-null (#4758)

Browse source
This commit is contained in:
heygsc 2024-08-08 21:12:19 +08:00 committed by GitHub
parent 790c551c5e
commit b20e3351fb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 28 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
crates/oxc_linter/src/rules/eslint/no_eq_null.rs
View file

@ -3,7 +3,7 @@ use std::fmt::Debug;
use oxc_ast::AstKind;
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::Span;
use oxc_span::{GetSpan, Span};
use oxc_syntax::operator::BinaryOperator;
use crate::{context::LintContext, rule::Rule, AstNode};
@ -31,7 +31,8 @@ declare_oxc_lint!(
/// }
/// ```
NoEqNull,
restriction
restriction,
fix_dangerous
);
impl Rule for NoEqNull {
@ -49,10 +50,24 @@ impl Rule for NoEqNull {
& binary_expression.left.is_null()
& bad_operator
{
ctx.diagnostic(no_eq_null_diagnostic(Span::new(
binary_expression.span.start,
binary_expression.span.end,
)));
ctx.diagnostic_with_dangerous_fix(
no_eq_null_diagnostic(Span::new(
binary_expression.span.start,
binary_expression.span.end,
)),
|fixer| {
let start = binary_expression.left.span().end;
let end = binary_expression.right.span().start;
let span = Span::new(start, end);
let new_operator_str =
if binary_expression.operator == BinaryOperator::Equality {
" === "
} else {
" !== "
};
fixer.replace(span, new_operator_str)
},
);
}
}
}
@ -66,5 +81,11 @@ fn test() {
let fail = vec!["if (x == null) { }", "if (x != null) { }", "do {} while (null == x)"];
Tester::new(NoEqNull::NAME, pass, fail).test_and_snapshot();
let fix = vec![
("if (x == null) { }", "if (x === null) { }"),
("if (x != null) { }", "if (x !== null) { }"),
("do {} while (null == x)", "do {} while (null === x)"),
];
Tester::new(NoEqNull::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
}