From ae1d38f60deb45abffaea0c550997e4d6da27d94 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Wed, 31 Jul 2024 03:33:05 +0000
Subject: [PATCH] perf(parser): fast path for ASCII when checking char after
 numeric literal (#4577)

Make a fast path for ASCII characters when lexer checks for invalid chars after a numeric literal. Also shorten the check for ASCII chars.
---
 crates/oxc_parser/src/lexer/numeric.rs | 29 ++++++++++++++++++++------
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/crates/oxc_parser/src/lexer/numeric.rs b/crates/oxc_parser/src/lexer/numeric.rs
index 1655306e3..8ab61659c 100644
--- a/crates/oxc_parser/src/lexer/numeric.rs
+++ b/crates/oxc_parser/src/lexer/numeric.rs
@@ -1,4 +1,4 @@
-use oxc_syntax::identifier::is_identifier_start;
+use oxc_syntax::identifier::{is_identifier_part_ascii, is_identifier_start};
 
 use super::{Kind, Lexer, Span};
 use crate::diagnostics;
@@ -189,12 +189,29 @@ impl<'a> Lexer<'a> {
     }
 
     fn check_after_numeric_literal(&mut self, kind: Kind) -> Kind {
-        let offset = self.offset();
-        // The SourceCharacter immediately following a NumericLiteral must not be an IdentifierStart or DecimalDigit.
-        let c = self.peek_char();
-        if c.is_none() || c.is_some_and(|ch| !ch.is_ascii_digit() && !is_identifier_start(ch)) {
-            return kind;
+        // The SourceCharacter immediately following a NumericLiteral must not be
+        // an IdentifierStart or DecimalDigit.
+        // Use a fast path for common case where next char is ASCII.
+        // NB: `!is_identifier_part_ascii(b as char)` is equivalent to
+        // `!b.is_ascii_digit() && !is_identifier_start_ascii(b as char)`
+        match self.peek_byte() {
+            Some(b) if b.is_ascii() => {
+                if !is_identifier_part_ascii(b as char) {
+                    return kind;
+                }
+            }
+            Some(_) => {
+                // Unicode
+                let c = self.peek_char().unwrap();
+                if !is_identifier_start(c) {
+                    return kind;
+                }
+            }
+            None => return kind,
         }
+
+        // Invalid next char
+        let offset = self.offset();
         self.consume_char();
         while let Some(c) = self.peek_char() {
             if is_identifier_start(c) {