dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(codegen): restrict visibility of internal methods (#6145)

Browse source 
add `pub(crate)` to `Codegen` methods that should only be used within `oxc_codegen`
This commit is contained in:
DonIsaac 2024-09-28 14:33:42 +00:00
parent be0030cdb8
commit ab187d1e22
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_codegen/src/binary_expr_visitor.rs
View file

@ -12,7 +12,7 @@ use oxc_syntax::{
use crate::{gen::GenExpr, Codegen, Context, Operator}; use crate::{gen::GenExpr, Codegen, Context, Operator};
#[derive(Clone, Copy)] #[derive(Clone, Copy)]
pub enum Binaryish<'a> { pub(crate) enum Binaryish<'a> {
Binary(&'a BinaryExpression<'a>), Binary(&'a BinaryExpression<'a>),
Logical(&'a LogicalExpression<'a>), Logical(&'a LogicalExpression<'a>),
} }

12
crates/oxc_codegen/src/comment.rs
View file

@ -7,16 +7,16 @@ use oxc_syntax::identifier::is_line_terminator;
use crate::Codegen; use crate::Codegen;
pub static ANNOTATION_MATCHER: Lazy<DoubleArrayAhoCorasick<usize>> = Lazy::new(|| { static ANNOTATION_MATCHER: Lazy<DoubleArrayAhoCorasick<usize>> = Lazy::new(|| {
let patterns = vec!["#__NO_SIDE_EFFECTS__", "@__NO_SIDE_EFFECTS__", "@__PURE__", "#__PURE__"]; let patterns = vec!["#__NO_SIDE_EFFECTS__", "@__NO_SIDE_EFFECTS__", "@__PURE__", "#__PURE__"];
DoubleArrayAhoCorasick::new(patterns).unwrap() DoubleArrayAhoCorasick::new(patterns).unwrap()
}); });
pub type CommentsMap = FxHashMap</* attached_to */ u32, Vec<Comment>>; pub(crate) type CommentsMap = FxHashMap</* attached_to */ u32, Vec<Comment>>;
impl<'a> Codegen<'a> { impl<'a> Codegen<'a> {
pub fn preserve_annotate_comments(&self) -> bool { pub(crate) fn preserve_annotate_comments(&self) -> bool {
self.comment_options.preserve_annotate_comments && !self.options.minify self.comment_options.preserve_annotate_comments && !self.options.minify
} }
@ -26,11 +26,11 @@ impl<'a> Codegen<'a> {
} }
} }
pub fn has_comment(&self, start: u32) -> bool { pub(crate) fn has_comment(&self, start: u32) -> bool {
self.comments.contains_key(&start) self.comments.contains_key(&start)
} }
pub fn has_annotation_comment(&self, start: u32) -> bool { pub(crate) fn has_annotation_comment(&self, start: u32) -> bool {
if !self.preserve_annotate_comments() { if !self.preserve_annotate_comments() {
return false; return false;
} }
@ -40,7 +40,7 @@ impl<'a> Codegen<'a> {
}) })
} }
pub fn has_non_annotation_comment(&self, start: u32) -> bool { pub(crate) fn has_non_annotation_comment(&self, start: u32) -> bool {
if !self.preserve_annotate_comments() { if !self.preserve_annotate_comments() {
return self.has_comment(start); return self.has_comment(start);
} }

2
crates/oxc_codegen/src/operator.rs
View file

@ -1,7 +1,7 @@
use oxc_syntax::operator::{BinaryOperator, UnaryOperator, UpdateOperator}; use oxc_syntax::operator::{BinaryOperator, UnaryOperator, UpdateOperator};
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub enum Operator { pub(crate) enum Operator {
Binary(BinaryOperator), Binary(BinaryOperator),
Unary(UnaryOperator), Unary(UnaryOperator),
Update(UpdateOperator), Update(UpdateOperator),