dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(linter): parse ts-directive manually (#845)

Browse source
This commit is contained in:
Devin-Yeung 2023-09-03 14:13:16 +08:00 committed by GitHub
parent 73be3eab4c
commit a969f69627
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
crates/oxc_linter/src/rules/typescript/ban_ts_comment.rs
View file

@ -1,4 +1,3 @@
use once_cell::sync::Lazy;
use oxc_diagnostics::{
miette::{self, Diagnostic},
thiserror::{self, Error},
@ -126,13 +125,11 @@ impl Rule for BanTsComment {
fn run_once(&self, ctx: &LintContext) {
let comments = ctx.semantic().trivias().comments();
for (start, comment) in comments {
let regex = if comment.is_single_line() { &SINGLELINE } else { &MULTILINE };
let raw = &ctx.semantic().source_text()[*start as usize..comment.end() as usize];
if let Some(captures) = regex.captures(raw) {
if let Some(captures) = find_ts_comment_directive(raw, comment.is_single_line()) {
// safe to unwrap, if capture success, it can always capture one of the four directives
let directive = captures.name("directive").unwrap().as_str();
let description = captures.name("description").map_or("", |m| m.as_str().trim());
let (directive, description) = (captures.0, captures.1.trim());
match self.option(directive) {
DirectiveConfig::Boolean(on) => {
@ -170,19 +167,6 @@ impl Rule for BanTsComment {
}
}
// regex to parse single line comment
static SINGLELINE: Lazy<Regex> = Lazy::new(|| {
Regex::new(r"^/*\s*@ts-(?P<directive>expect-error|ignore|check|nocheck)(?P<description>.*)")
.unwrap()
});
// regex to parse multiline comment
static MULTILINE: Lazy<Regex> = Lazy::new(|| {
Regex::new(
r"^\s*(?:/|\*)*\s*@ts-(?P<directive>expect-error|ignore|check|nocheck)(?P<description>.*)",
)
.unwrap()
});
impl BanTsComment {
/// get the option for a given directive, caller should guarantee
/// the directive should be one of the ignore/check/nocheck/expect-error
@ -197,6 +181,30 @@ impl BanTsComment {
}
}
pub fn find_ts_comment_directive(raw: &str, single_line: bool) -> Option<(&str, &str)> {
let prefix = "@ts-";
// For multi-line comments, get the last line
let mut lines = raw.lines();
let line = lines.next_back()?;
let index = line.find(prefix)?;
if !line[..index]
.chars()
.all(|c| c.is_whitespace() || if single_line { c == '/' } else { c == '*' || c == '/' })
{
return None;
}
let multi_len = lines.map(|line| line.len() + 1).sum::<usize>();
let start = index + prefix.len();
for directive in ["expect-error", "ignore", "nocheck", "check"] {
if line.get(start..start + directive.len()) == Some(directive) {
let start = multi_len + index + prefix.len();
let end = start + directive.len();
return Some((&raw[start..end], &raw[end..]));
}
}
None
}
#[test]
#[allow(clippy::too_many_lines)]
fn test() {