From a8e4c3333c76873713ade2ce69791aaf3bfc692f Mon Sep 17 00:00:00 2001 From: Dunqing Date: Fri, 17 Nov 2023 19:00:29 +0800 Subject: [PATCH] feat(prettier): wrap a group in BinaryExpression (#1370) --- crates/oxc_prettier/src/format/mod.rs | 11 +++++++---- tasks/prettier_conformance/prettier.snap.md | 3 +-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/crates/oxc_prettier/src/format/mod.rs b/crates/oxc_prettier/src/format/mod.rs index 7c70312b3..4fe675c23 100644 --- a/crates/oxc_prettier/src/format/mod.rs +++ b/crates/oxc_prettier/src/format/mod.rs @@ -911,11 +911,14 @@ impl<'a> Format<'a> for UnaryExpression<'a> { impl<'a> Format<'a> for BinaryExpression<'a> { fn format(&self, p: &mut Prettier<'a>) -> Doc<'a> { - binaryish::print_binaryish_expression( + group!( p, - &BinaryishLeft::Expression(&self.left), - BinaryishOperator::BinaryOperator(self.operator), - &self.right, + binaryish::print_binaryish_expression( + p, + &BinaryishLeft::Expression(&self.left), + BinaryishOperator::BinaryOperator(self.operator), + &self.right, + ) ) } } diff --git a/tasks/prettier_conformance/prettier.snap.md b/tasks/prettier_conformance/prettier.snap.md index 8668104c2..7211f62e9 100644 --- a/tasks/prettier_conformance/prettier.snap.md +++ b/tasks/prettier_conformance/prettier.snap.md @@ -1,4 +1,4 @@ -Compatibility: 14/173 (8.09%) +Compatibility: 15/173 (8.67%) # Failed @@ -82,7 +82,6 @@ Compatibility: 14/173 (8.09%) * import-attributes * import-attributes/bracket-spacing * import-reflection -* in * label * last-argument-expansion * line-suffix-boundary