dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): fix unwanted plugin rules being enabled

Browse source
This commit is contained in:
Boshen 2024-04-22 15:52:13 +08:00
parent b29aabd6f1
commit a5a73517f8
No known key found for this signature in database
GPG key ID: 234DA6A7079C6801
1 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
crates/oxc_linter/src/options.rs
View file

@ -185,14 +185,19 @@ impl LintOptions {
AllowWarnDeny::Deny | AllowWarnDeny::Warn => { AllowWarnDeny::Deny | AllowWarnDeny::Warn => {
match maybe_category { match maybe_category {
Some(category) => rules.extend( Some(category) => rules.extend(
RULES.iter().filter(|rule| rule.category() == category).cloned(), all_rules.iter().filter(|rule| rule.category() == category).cloned(),
), ),
None => { None => {
if name_or_category == "all" { if name_or_category == "all" {
rules.extend(all_rules.iter().cloned()); rules.extend(
all_rules
.iter()
.filter(|rule| rule.category() != RuleCategory::Nursery)
.cloned(),
);
} else { } else {
rules.extend( rules.extend(
RULES all_rules
.iter() .iter()
.filter(|rule| rule.name() == name_or_category) .filter(|rule| rule.name() == name_or_category)
.cloned(), .cloned(),
@ -232,11 +237,7 @@ impl LintOptions {
fn get_filtered_rules(&self) -> Vec<RuleEnum> { fn get_filtered_rules(&self) -> Vec<RuleEnum> {
RULES RULES
.iter() .iter()
.filter(|rule| { .filter(|rule| match rule.plugin_name() {
if rule.category() == RuleCategory::Nursery {
return false;
}
match rule.plugin_name() {
IMPORT_PLUGIN_NAME if !self.import_plugin => false, IMPORT_PLUGIN_NAME if !self.import_plugin => false,
JSDOC_PLUGIN_NAME if !self.jsdoc_plugin => false, JSDOC_PLUGIN_NAME if !self.jsdoc_plugin => false,
JEST_PLUGIN_NAME if !self.jest_plugin => false, JEST_PLUGIN_NAME if !self.jest_plugin => false,
@ -244,7 +245,6 @@ impl LintOptions {
NEXTJS_PLUGIN_NAME if !self.nextjs_plugin => false, NEXTJS_PLUGIN_NAME if !self.nextjs_plugin => false,
REACT_PERF_PLUGIN_NAME if !self.react_perf_plugin => false, REACT_PERF_PLUGIN_NAME if !self.react_perf_plugin => false,
_ => true, _ => true,
}
}) })
.cloned() .cloned()
.collect::<Vec<_>>() .collect::<Vec<_>>()