dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(prettier): add more on function parameters format (#1356)

Browse source
This commit is contained in:
Wenzhe Wang 2023-11-16 22:37:02 +08:00 committed by GitHub
parent 9754ef0d95
commit a3658ca5f9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 35 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
crates/oxc_prettier/src/format/function.rs
View file

@ -23,11 +23,19 @@ impl<'a> Prettier<'a> {
if let Some(id) = &func.id {
parts.push(self.str(id.name.as_str()));
}
parts.push(func.params.format(self));
if should_group_function_parameters(func) {
parts.push(group!(self, func.params.format(self)));
} else {
parts.push(func.params.format(self));
}
if let Some(body) = &func.body {
parts.push(ss!(" "));
parts.push(body.format(self));
}
if self.options.semi && (func.is_ts_declare_function() || func.body.is_none()) {
parts.push(self.str(";"));
}
Doc::Array(parts)
}
@ -56,3 +64,29 @@ impl<'a> Prettier<'a> {
Doc::Array(parts)
}
}
fn should_group_function_parameters(func: &Function) -> bool {
let Some(return_type) = &func.return_type else {
return false;
};
let type_parameters = func.type_parameters.as_ref().map(|x| &x.params);
if let Some(type_parameter) = type_parameters {
if type_parameter.len() > 1 {
return false;
}
if let Some(type_parameter) = type_parameter.first() {
if type_parameter.constraint.is_some() || type_parameter.default.is_some() {
return false;
}
}
}
// TODO: need union `willBreak`
func.params.parameters_count() == 1
&& (matches!(
return_type.type_annotation,
TSType::TSTypeLiteral(_) | TSType::TSMappedType(_)
))
}