dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): dereference IDs as soon as possible (#6821)

Browse source 
Style nit. Dereference `&ScopeId` to `ScopeId` (and other IDs) as early as possible. `&ScopeId` is 8 bytes, whereas `ScopeId` is 4 bytes.

In simple cases like these, compiler will optimize it anyway, but still I think it's a better pattern to dererence early. In more complicated cases, it will be better for performance, and in my opinion, it makes things clearer if vars called `scope_id` are always a `ScopeId`, not sometimes a `&ScopeId`.
This commit is contained in:
overlookmotel 2024-10-23 12:57:55 +00:00
parent 11077708bb
commit a148023fad
4 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_linter/src/rules/eslint/no_unused_vars/mod.rs
View file

@ -377,8 +377,8 @@ impl Symbol<'_, '_> {
fn is_in_declare_global(&self) -> bool { fn is_in_declare_global(&self) -> bool {
self.scopes() self.scopes()
.ancestors(self.scope_id()) .ancestors(self.scope_id())
.filter(|scope_id| { .filter(|&scope_id| {
let flags = self.scopes().get_flags(*scope_id); let flags = self.scopes().get_flags(scope_id);
flags.contains(ScopeFlags::TsModuleBlock) flags.contains(ScopeFlags::TsModuleBlock)
}) })
.any(|ambient_module_scope_id| { .any(|ambient_module_scope_id| {

4
crates/oxc_linter/src/rules/jest/no_mocks_import.rs
View file

@ -48,8 +48,8 @@ impl Rule for NoMocksImport {
return; return;
}; };
for reference_id in require_reference_ids { for &reference_id in require_reference_ids {
let reference = ctx.symbols().get_reference(*reference_id); let reference = ctx.symbols().get_reference(reference_id);
let Some(parent) = ctx.nodes().parent_node(reference.node_id()) else { let Some(parent) = ctx.nodes().parent_node(reference.node_id()) else {
return; return;
}; };

8
crates/oxc_linter/src/rules/typescript/no_unsafe_declaration_merging.rs
View file

@ -43,9 +43,9 @@ impl Rule for NoUnsafeDeclarationMerging {
match node.kind() { match node.kind() {
AstKind::Class(decl) => { AstKind::Class(decl) => {
if let Some(ident) = decl.id.as_ref() { if let Some(ident) = decl.id.as_ref() {
for (_, symbol_id) in ctx.semantic().scopes().get_bindings(node.scope_id()) { for (_, &symbol_id) in ctx.semantic().scopes().get_bindings(node.scope_id()) {
if let AstKind::TSInterfaceDeclaration(scope_interface) = if let AstKind::TSInterfaceDeclaration(scope_interface) =
get_symbol_kind(*symbol_id, ctx) get_symbol_kind(symbol_id, ctx)
{ {
check_and_diagnostic(ident, &scope_interface.id, ctx); check_and_diagnostic(ident, &scope_interface.id, ctx);
} }
@ -53,8 +53,8 @@ impl Rule for NoUnsafeDeclarationMerging {
} }
} }
AstKind::TSInterfaceDeclaration(decl) => { AstKind::TSInterfaceDeclaration(decl) => {
for (_, symbol_id) in ctx.semantic().scopes().get_bindings(node.scope_id()) { for (_, &symbol_id) in ctx.semantic().scopes().get_bindings(node.scope_id()) {
if let AstKind::Class(scope_class) = get_symbol_kind(*symbol_id, ctx) { if let AstKind::Class(scope_class) = get_symbol_kind(symbol_id, ctx) {
if let Some(scope_class_ident) = scope_class.id.as_ref() { if let Some(scope_class_ident) = scope_class.id.as_ref() {
check_and_diagnostic(&decl.id, scope_class_ident, ctx); check_and_diagnostic(&decl.id, scope_class_ident, ctx);
} }

9
crates/oxc_linter/src/utils/jest.rs
View file

@ -215,11 +215,10 @@ fn collect_ids_referenced_to_import<'a, 'c>(
if matches!(import_decl.source.value.as_str(), "@jest/globals" | "vitest") { if matches!(import_decl.source.value.as_str(), "@jest/globals" | "vitest") {
let original = find_original_name(import_decl, name); let original = find_original_name(import_decl, name);
let mut ret = vec![]; let ret = reference_ids
for reference_id in reference_ids { .iter()
ret.push((*reference_id, original)); .map(|&reference_id| (reference_id, original))
} .collect::<Vec<_>>();
return Some(ret); return Some(ret);
} }
} }