From 9c3d1631a48f711cd01f658f00a814922c3e3266 Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Fri, 31 May 2024 12:34:48 +0000 Subject: [PATCH] refactor(ast): rename function params (#3487) Rename function params from `_kind` to `kind`. This has no practical effect but makes Rust Analyser give nicer param name hints when using these APIs. --- crates/oxc_ast/src/visit/visit.rs | 9 ++++++--- crates/oxc_ast/src/visit/visit_mut.rs | 9 ++++++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/crates/oxc_ast/src/visit/visit.rs b/crates/oxc_ast/src/visit/visit.rs index 50bd060b8..d694f7c03 100644 --- a/crates/oxc_ast/src/visit/visit.rs +++ b/crates/oxc_ast/src/visit/visit.rs @@ -13,10 +13,13 @@ use walk::*; /// Syntax tree traversal pub trait Visit<'a>: Sized { - fn enter_node(&mut self, _kind: AstKind<'a>) {} - fn leave_node(&mut self, _kind: AstKind<'a>) {} + #[allow(unused_variables)] + fn enter_node(&mut self, kind: AstKind<'a>) {} + #[allow(unused_variables)] + fn leave_node(&mut self, kind: AstKind<'a>) {} - fn enter_scope(&mut self, _flags: ScopeFlags) {} + #[allow(unused_variables)] + fn enter_scope(&mut self, flags: ScopeFlags) {} fn leave_scope(&mut self) {} fn alloc(&self, t: &T) -> &'a T { diff --git a/crates/oxc_ast/src/visit/visit_mut.rs b/crates/oxc_ast/src/visit/visit_mut.rs index a17172f12..a4a3494e2 100644 --- a/crates/oxc_ast/src/visit/visit_mut.rs +++ b/crates/oxc_ast/src/visit/visit_mut.rs @@ -10,10 +10,13 @@ use self::walk_mut::*; /// Syntax tree traversal to mutate an exclusive borrow of a syntax tree in place. pub trait VisitMut<'a>: Sized { - fn enter_node(&mut self, _kind: AstType) {} - fn leave_node(&mut self, _kind: AstType) {} + #[allow(unused_variables)] + fn enter_node(&mut self, kind: AstType) {} + #[allow(unused_variables)] + fn leave_node(&mut self, kind: AstType) {} - fn enter_scope(&mut self, _flags: ScopeFlags) {} + #[allow(unused_variables)] + fn enter_scope(&mut self, flags: ScopeFlags) {} fn leave_scope(&mut self) {} fn visit_program(&mut self, program: &mut Program<'a>) {