dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(semantic): avoid var hosting insert the var variable to the CatchClause scope (#4337)

Browse source 
related: #4192 #4323

I will figure it out #4323 later
This commit is contained in:
Dunqing 2024-07-18 02:52:14 +00:00
parent 7afa1f06c3
commit 9badac030d
2 changed files with 7 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crates/oxc_semantic/src/binder.rs
View file

@ -46,8 +46,13 @@ impl<'a> Binder for VariableDeclarator<'a> {
let mut var_scope_ids = vec![]; let mut var_scope_ids = vec![];
if !builder.current_scope_flags().is_var() { if !builder.current_scope_flags().is_var() {
for scope_id in builder.scope.ancestors(current_scope_id).skip(1) { for scope_id in builder.scope.ancestors(current_scope_id).skip(1) {
let flag = builder.scope.get_flags(scope_id);
// Skip the catch clause, the scope bindings have been cloned to the child block scope
if flag.is_catch_clause() {
continue;
}
var_scope_ids.push(scope_id); var_scope_ids.push(scope_id);
if builder.scope.get_flags(scope_id).is_var() { if flag.is_var() {
break; break;
} }
} }

15
tasks/coverage/parser_typescript.snap
View file

@ -2,7 +2,7 @@ commit: d8086f14
parser_typescript Summary: parser_typescript Summary:
AST Parsed : 6444/6456 (99.81%) AST Parsed : 6444/6456 (99.81%)
Positive Passed: 6421/6456 (99.46%) Positive Passed: 6422/6456 (99.47%)
Negative Passed: 1160/5653 (20.52%) Negative Passed: 1160/5653 (20.52%)
Expect Syntax Error: "compiler/ClassDeclaration10.ts" Expect Syntax Error: "compiler/ClassDeclaration10.ts"
Expect Syntax Error: "compiler/ClassDeclaration11.ts" Expect Syntax Error: "compiler/ClassDeclaration11.ts"
@ -4639,19 +4639,6 @@ Expect to Parse: "compiler/withStatementInternalComments.ts"
2 │ /*1*/ with /*2*/ ( /*3*/ false /*4*/ ) /*5*/ {} 2 │ /*1*/ with /*2*/ ( /*3*/ false /*4*/ ) /*5*/ {}
· ──── · ────
╰──── ╰────
Expect to Parse: "conformance/async/es6/asyncWithVarShadowing_es6.ts"
× Identifier `x` has already been declared
╭─[conformance/async/es6/asyncWithVarShadowing_es6.ts:130:14]
129 │ }
130 │ catch ({ x }) {
· ┬
· ╰── `x` has already been declared here
131 │ var x;
· ┬
· ╰── It can not be redeclared here
132 │ }
╰────
Expect to Parse: "conformance/classes/propertyMemberDeclarations/staticPropertyNameConflicts.ts" Expect to Parse: "conformance/classes/propertyMemberDeclarations/staticPropertyNameConflicts.ts"
× Classes may not have a static property named prototype × Classes may not have a static property named prototype