dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter/no-null): incorrect fixer for NullLiteral within ReturnStatement (#5247)

Browse source 
close: #5194

It’s a long time no contributed to Linter, I'd like to try it
This commit is contained in:
Dunqing 2024-08-27 03:51:55 +00:00
parent a6e97690a7
commit 9953fa54a4
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
crates/oxc_linter/src/rules/unicorn/no_null.rs
View file

@ -199,7 +199,17 @@ impl Rule for NoNull {
}
(AstKind::ReturnStatement(_), _) => {
ctx.diagnostic_with_fix(no_null_diagnostic(null_literal.span), |fixer| {
fixer.delete(null_literal)
let mut null_span = null_literal.span;
// Find the last parent that is a TSAsExpression (`null as any`) or TSNonNullExpression (`null!`)
for parent in ctx.nodes().iter_parents(node.id()).skip(1) {
if matches!(
parent.kind(),
AstKind::TSAsExpression(_) | AstKind::TSNonNullExpression(_)
) {
null_span = parent.kind().span();
}
}
fixer.delete(&null_span)
});
}
(AstKind::SwitchCase(_), Some(AstKind::SwitchStatement(switch))) => {
@ -369,6 +379,8 @@ fn test() {
"if (foo === undefined || foo === undefined) {}",
Some(check_strict_equality(true)),
),
("() => { return null! }", "() => { return }", None),
("() => { return null as any as typeof Array }", "() => { return }", None),
];
Tester::new(NoNull::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
}