dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(transformer/class-properties): fix SymbolFlags for _super function (#7709)

Browse source 
Fix `SymbolFlags` for generated `_super` function outside class.
This commit is contained in:
overlookmotel 2024-12-08 01:41:35 +00:00
parent de5b0b63a9
commit 97e4185c19
3 changed files with 5 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_transformer/src/es2022/class_properties/constructor.rs
View file

@ -377,7 +377,7 @@ impl<'a, 'c> ConstructorParamsSuperReplacer<'a, 'c> {
self.ctx.generate_uid(
"super",
self.ctx.current_scope_id(),
SymbolFlags::FunctionScopedVariable,
SymbolFlags::BlockScopedVariable,
)
});

19
tasks/transform_conformance/snapshots/babel.snap.md
View file

@ -1,6 +1,6 @@
commit: 54a8389f
Passed: 434/846
Passed: 437/846
# All Passed:
* babel-plugin-transform-class-static-block
@ -276,7 +276,7 @@ x Output mismatch
x Output mismatch
# babel-plugin-transform-class-properties (107/264)
# babel-plugin-transform-class-properties (110/264)
* assumption-constantSuper/complex-super-class/input.js
x Output mismatch
@ -821,21 +821,6 @@ x Output mismatch
* public/delete-super-property/input.js
x Output mismatch
* public/derived-super-in-default-params/input.js
Symbol flags mismatch for "_super":
after transform: SymbolId(2): SymbolFlags(FunctionScopedVariable)
rebuilt : SymbolId(0): SymbolFlags(BlockScopedVariable)
* public/derived-super-in-default-params-complex/input.js
Symbol flags mismatch for "_super":
after transform: SymbolId(2): SymbolFlags(FunctionScopedVariable)
rebuilt : SymbolId(0): SymbolFlags(BlockScopedVariable)
* public/derived-super-in-default-params-in-arrow/input.js
Symbol flags mismatch for "_super":
after transform: SymbolId(2): SymbolFlags(FunctionScopedVariable)
rebuilt : SymbolId(0): SymbolFlags(BlockScopedVariable)
* public/extracted-this/input.js
x Output mismatch

13
tasks/transform_conformance/snapshots/oxc.snap.md
View file

@ -1,8 +1,9 @@
commit: 54a8389f
Passed: 94/106
Passed: 95/106
# All Passed:
* babel-plugin-transform-class-properties
* babel-plugin-transform-class-static-block
* babel-plugin-transform-nullish-coalescing-operator
* babel-plugin-transform-optional-catch-binding
@ -15,16 +16,6 @@ Passed: 94/106
* regexp
# babel-plugin-transform-class-properties (1/2)
* super-in-constructor-strict/input.js
Symbol flags mismatch for "_super":
after transform: SymbolId(6): SymbolFlags(FunctionScopedVariable)
rebuilt : SymbolId(1): SymbolFlags(BlockScopedVariable)
Symbol flags mismatch for "_super2":
after transform: SymbolId(7): SymbolFlags(FunctionScopedVariable)
rebuilt : SymbolId(5): SymbolFlags(BlockScopedVariable)
# babel-plugin-transform-async-to-generator (14/15)
* super/nested/input.js
x Output mismatch