dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): reduce nested if statements in eslint/no_this_before_super (#5485)

Browse source
This commit is contained in:
IWANABETHATGUY 2024-09-05 13:21:18 +00:00
parent bc7be70077
commit 979c16c486
1 changed files with 11 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
crates/oxc_linter/src/rules/eslint/no_this_before_super.rs
View file

@ -66,7 +66,7 @@ impl Rule for NoThisBeforeSuper {
for node in semantic.nodes().iter() { for node in semantic.nodes().iter() {
match node.kind() { match node.kind() {
AstKind::Function(_) | AstKind::ArrowFunctionExpression(_) => { AstKind::Function(_) | AstKind::ArrowFunctionExpression(_) => {
if Self::is_wanted_node(node, ctx) { if Self::is_wanted_node(node, ctx).unwrap_or_default() {
wanted_nodes.push(node); wanted_nodes.push(node);
} }
} }
@ -133,26 +133,20 @@ impl Rule for NoThisBeforeSuper {
} }
impl NoThisBeforeSuper { impl NoThisBeforeSuper {
fn is_wanted_node(node: &AstNode, ctx: &LintContext<'_>) -> bool { fn is_wanted_node(node: &AstNode, ctx: &LintContext<'_>) -> Option<bool> {
if let Some(parent) = ctx.nodes().parent_node(node.id()) { let parent = ctx.nodes().parent_node(node.id())?;
if let AstKind::MethodDefinition(mdef) = parent.kind() { if let AstKind::MethodDefinition(mdef) = parent.kind() {
if matches!(mdef.kind, MethodDefinitionKind::Constructor) { if matches!(mdef.kind, MethodDefinitionKind::Constructor) {
let parent_2 = ctx.nodes().parent_node(parent.id()); let parent_2 = ctx.nodes().parent_node(parent.id())?;
if let Some(parent_2) = parent_2 { let parent_3 = ctx.nodes().parent_node(parent_2.id())?;
let parent_3 = ctx.nodes().parent_node(parent_2.id()); if let AstKind::Class(c) = parent_3.kind() {
if let Some(parent_3) = parent_3 { let super_class = c.super_class.as_ref()?;
if let AstKind::Class(c) = parent_3.kind() { return Some(!matches!(super_class, Expression::NullLiteral(_)));
if let Some(super_class) = &c.super_class {
return !matches!(super_class, Expression::NullLiteral(_));
}
}
}
}
} }
} }
} }
false Some(false)
} }
fn analyze( fn analyze(