dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(traverse): add methods to BoundIdentifier + MaybeBoundIdentifier to create SimpleAssignmentTargets (#7418)

Browse source 
We had methods to create `AssignmentTarget`s. Add methods to create `SimpleAssignmentTarget`s too.
This commit is contained in:
overlookmotel 2024-11-22 12:31:29 +00:00
parent eb39a50a2e
commit 971c91a2e8
2 changed files with 116 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

59
crates/oxc_traverse/src/context/bound_identifier.rs
View file

@ -1,7 +1,7 @@
use oxc_ast::{
ast::{
AssignmentTarget, BindingIdentifier, BindingPattern, BindingPatternKind, Expression,
IdentifierReference,
IdentifierReference, SimpleAssignmentTarget,
},
NONE,
};
@ -120,6 +120,14 @@ impl<'a> BoundIdentifier<'a> {
self.create_spanned_write_target(SPAN, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, which is written to, with dummy `Span`
pub fn create_write_simple_target(
&self,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_write_simple_target(SPAN, ctx)
}
/// Create `IdentifierReference` referencing this binding, which is written to, with specified `Span`
pub fn create_spanned_write_reference(
&self,
@ -147,6 +155,15 @@ impl<'a> BoundIdentifier<'a> {
self.create_spanned_target(span, ReferenceFlags::Write, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, which is written to, with specified `Span`
pub fn create_spanned_write_simple_target(
&self,
span: Span,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_simple_target(span, ReferenceFlags::Write, ctx)
}
// --- Read and write ---
/// Create `IdentifierReference` referencing this binding, which is read from + written to,
@ -170,6 +187,15 @@ impl<'a> BoundIdentifier<'a> {
self.create_spanned_read_write_target(SPAN, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, which is read from + written to,
/// with dummy `Span`
pub fn create_read_write_simple_target(
&self,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_read_write_simple_target(SPAN, ctx)
}
/// Create `IdentifierReference` referencing this binding, which is read from + written to,
/// with specified `Span`
pub fn create_spanned_read_write_reference(
@ -200,6 +226,16 @@ impl<'a> BoundIdentifier<'a> {
self.create_spanned_target(span, ReferenceFlags::Read | ReferenceFlags::Write, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, which is read from + written to,
/// with specified `Span`
pub fn create_spanned_read_write_simple_target(
&self,
span: Span,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_simple_target(span, ReferenceFlags::Read | ReferenceFlags::Write, ctx)
}
// --- Specified ReferenceFlags ---
/// Create `IdentifierReference` referencing this binding, with specified `ReferenceFlags`
@ -229,6 +265,15 @@ impl<'a> BoundIdentifier<'a> {
self.create_spanned_target(SPAN, flags, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, with specified `ReferenceFlags`
pub fn create_simple_target(
&self,
flags: ReferenceFlags,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_simple_target(SPAN, flags, ctx)
}
/// Create `IdentifierReference` referencing this binding, with specified `Span` and `ReferenceFlags`
pub fn create_spanned_reference(
&self,
@ -261,4 +306,16 @@ impl<'a> BoundIdentifier<'a> {
let ident = self.create_spanned_reference(span, flags, ctx);
AssignmentTarget::AssignmentTargetIdentifier(ctx.alloc(ident))
}
/// Create `SimpleAssignmentTarget::AssignmentTargetIdentifier` referencing this binding,
/// with specified `Span` and `ReferenceFlags`
pub fn create_spanned_simple_target(
&self,
span: Span,
flags: ReferenceFlags,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
let ident = self.create_spanned_reference(span, flags, ctx);
SimpleAssignmentTarget::AssignmentTargetIdentifier(ctx.alloc(ident))
}
}

59
crates/oxc_traverse/src/context/maybe_bound_identifier.rs
View file

@ -1,4 +1,4 @@
use oxc_ast::ast::{AssignmentTarget, Expression, IdentifierReference};
use oxc_ast::ast::{AssignmentTarget, Expression, IdentifierReference, SimpleAssignmentTarget};
use oxc_span::{Atom, Span, SPAN};
use oxc_syntax::{reference::ReferenceFlags, symbol::SymbolId};
@ -102,6 +102,14 @@ impl<'a> MaybeBoundIdentifier<'a> {
self.create_spanned_write_target(SPAN, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, which is written to, with dummy `Span`
pub fn create_write_simple_target(
&self,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_write_simple_target(SPAN, ctx)
}
/// Create `IdentifierReference` referencing this binding, which is written to, with specified `Span`
pub fn create_spanned_write_reference(
&self,
@ -129,6 +137,15 @@ impl<'a> MaybeBoundIdentifier<'a> {
self.create_spanned_target(span, ReferenceFlags::Write, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, which is written to, with specified `Span`
pub fn create_spanned_write_simple_target(
&self,
span: Span,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_simple_target(span, ReferenceFlags::Write, ctx)
}
// --- Read and write ---
/// Create `IdentifierReference` referencing this binding, which is read from + written to,
@ -152,6 +169,15 @@ impl<'a> MaybeBoundIdentifier<'a> {
self.create_spanned_read_write_target(SPAN, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, which is read from + written to,
/// with dummy `Span`
pub fn create_read_write_simple_target(
&self,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_read_write_simple_target(SPAN, ctx)
}
/// Create `IdentifierReference` referencing this binding, which is read from + written to,
/// with specified `Span`
pub fn create_spanned_read_write_reference(
@ -182,6 +208,16 @@ impl<'a> MaybeBoundIdentifier<'a> {
self.create_spanned_target(span, ReferenceFlags::Read | ReferenceFlags::Write, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, which is read from + written to,
/// with specified `Span`
pub fn create_spanned_read_write_simple_target(
&self,
span: Span,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_simple_target(span, ReferenceFlags::Read | ReferenceFlags::Write, ctx)
}
// --- Specified ReferenceFlags ---
/// Create `IdentifierReference` referencing this binding, with specified `ReferenceFlags`
@ -211,6 +247,15 @@ impl<'a> MaybeBoundIdentifier<'a> {
self.create_spanned_target(SPAN, flags, ctx)
}
/// Create `SimpleAssignmentTarget` referencing this binding, with specified `ReferenceFlags`
pub fn create_simple_target(
&self,
flags: ReferenceFlags,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
self.create_spanned_simple_target(SPAN, flags, ctx)
}
/// Create `IdentifierReference` referencing this binding, with specified `Span` and `ReferenceFlags`
pub fn create_spanned_reference(
&self,
@ -243,4 +288,16 @@ impl<'a> MaybeBoundIdentifier<'a> {
let ident = self.create_spanned_reference(span, flags, ctx);
AssignmentTarget::AssignmentTargetIdentifier(ctx.alloc(ident))
}
/// Create `SimpleAssignmentTarget::AssignmentTargetIdentifier` referencing this binding,
/// with specified `Span` and `ReferenceFlags`
pub fn create_spanned_simple_target(
&self,
span: Span,
flags: ReferenceFlags,
ctx: &mut TraverseCtx<'a>,
) -> SimpleAssignmentTarget<'a> {
let ident = self.create_spanned_reference(span, flags, ctx);
SimpleAssignmentTarget::AssignmentTargetIdentifier(ctx.alloc(ident))
}
}