dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter/import): check ObjectPattern syntax in namespace (#2691)

Browse source
This commit is contained in:
Dunqing 2024-03-18 12:55:55 +08:00 committed by GitHub
parent 64db5643ce
commit 95ac265504
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 52 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
crates/oxc_linter/src/rules/import/namespace.rs
View file

@ -1,4 +1,4 @@
use oxc_ast::AstKind;
use oxc_ast::{ast::BindingPatternKind, AstKind};
use oxc_diagnostics::{
miette::{self, Diagnostic},
thiserror::Error,
@ -109,7 +109,6 @@ impl Rule for Namespace {
check_binding_exported(name, span);
}
}
AstKind::JSXMemberExpressionObject(_) => {
if let Some(AstKind::JSXMemberExpression(expr)) =
ctx.nodes().parent_kind(node.id())
@ -117,6 +116,16 @@ impl Rule for Namespace {
check_binding_exported(&expr.property.name, expr.property.span);
}
}
AstKind::VariableDeclarator(decl) => {
let BindingPatternKind::ObjectPattern(pattern) = &decl.id.kind else {
return;
};
pattern.properties.iter().for_each(|property| {
if let Some(name) = property.key.name() {
check_binding_exported(&name, property.key.span());
}
});
}
_ => {}
}
}
@ -144,30 +153,28 @@ fn test() {
// console.log(foo.Qux1);
// console.log(foo.Qux2);"#,
r"import * as foo from './common';",
// r#"import * as names from "./named-exports"; const { a } = names"#,
// r#"import * as names from "./named-exports"; const { d: c } = names"#,
// r#"import * as names from "./named-exports";
r#"import * as names from "./named-exports"; const { a } = names"#,
r#"import * as names from "./named-exports"; const { d: c } = names"#,
r#"import * as names from "./named-exports";
// const { c } = foo,
// { length } = "names",
// alt = names;"#,
// r#"import * as names from "./named-exports"; const { ExportedClass: { length } } = names"#,
// r#"import * as names from "./named-exports"; function b(names) { const { c } = names }"#,
// r#"import * as names from "./named-exports"; function b() { let names = null; const { c } = names }"#,
// r#"import * as names from "./named-exports"; const x = function names() { const { c } = names }"#,
// r#"export * as names from "./named-exports""#,
// r#"export defport, * as names from "./named-exports""#,
r#"import * as names from "./named-exports"; const { ExportedClass: { length } } = names"#,
r#"import * as names from "./named-exports"; function b(names) { const { c } = names }"#,
r#"import * as names from "./named-exports"; function b() { let names = null; const { c } = names }"#,
r#"import * as names from "./named-exports"; const x = function names() { const { c } = names }"#,
r#"export * as names from "./named-exports""#,
// r#"export * as names from "./does-not-exist""#,
// r#"import * as Endpoints from "./issue-195/Endpoints"; console.log(Endpoints.Users)"#,
// r#"function x() { console.log((names.b).c); } import * as names from "./named-exports";"#,
r#"function x() { console.log((names.b).c); } import * as names from "./named-exports";"#,
// r#"import * as names from './default-export';"#,
// r#"import * as names from './default-export'; console.log(names.default)"#,
// r#"export * as names from "./default-export""#,
// r#"export defport, * as names from "./default-export""#,
// r#"import * as names from './named-exports'; console.log(names['a']);"#,
// r#"import * as names from './named-exports'; const {a, b, ...rest} = names;"#,
// r#"import * as names from './named-exports'; const {a, b, ...rest} = names;"#,
// r#"import * as ns from './re-export-common'; const {foo} = ns;"#,
// r#"import * as Names from "./named-exports"; const Foo = <Names.a/>"#,
// r"import * as names from './named-exports'; console.log(names['a']);",
r"import * as names from './named-exports'; const {a, b, ...rest} = names;",
r"import * as ns from './re-export-common'; const {foo} = ns;",
r#"import * as Names from "./named-exports"; const Foo = <Names.a/>"#,
// r#"import * as foo from "./typescript-declare-nested"
// foo.bar.MyFunction()"#,
// r#"import { foobar } from "./typescript-declare-interface""#,
@ -220,10 +227,10 @@ fn test() {
r"import * as names from './named-exports'; console.log(names['a']);",
r"import * as foo from './bar'; foo.foo = 'y';",
r"import * as foo from './bar'; foo.x = 'y';",
// r#"import * as names from "./named-exports"; const { c } = names"#,
// r#"import * as names from "./named-exports"; function b() { const { c } = names }"#,
// r#"import * as names from "./named-exports"; const { c: d } = names"#,
// r#"import * as names from "./named-exports"; const { c: { d } } = names"#,
r#"import * as names from "./named-exports"; const { c } = names"#,
r#"import * as names from "./named-exports"; function b() { const { c } = names }"#,
r#"import * as names from "./named-exports"; const { c: d } = names"#,
r#"import * as names from "./named-exports"; const { c: { d } } = names"#,
// r#"import * as Endpoints from "./issue-195/Endpoints"; console.log(Endpoints.Foo)"#,
// r#"import * as namespace from './malformed.js';"#,
// r#"import b from './deep/default'; console.log(b.e)"#,

24
crates/oxc_linter/src/snapshots/namespace.snap
View file

@ -33,6 +33,30 @@ expression: namespace
· ─
╰────
⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:51]
1 │ import * as names from "./named-exports"; const { c } = names
· ─
╰────
⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:66]
1 │ import * as names from "./named-exports"; function b() { const { c } = names }
· ─
╰────
⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:51]
1 │ import * as names from "./named-exports"; const { c: d } = names
· ─
╰────
⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:51]
1 │ import * as names from "./named-exports"; const { c: { d } } = names
· ─
╰────
⚠ eslint-plugin-import(namespace): "c" not found in imported namespace "./named-exports".
╭─[index.js:1:19]
1 │ console.log(names.c); import * as names from './named-exports';