dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 20:32:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(semantic): missing SymbolFlags::Export when identifier used in ExportDefaultDeclaration (#2837)

Browse source
This commit is contained in:
Dunqing 2024-03-27 14:13:25 +08:00 committed by GitHub
parent 528744ca0a
commit 947a9f05e8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 18 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
crates/oxc_semantic/src/builder.rs
View file

@ -7,6 +7,7 @@ use oxc_ast::{ast::*, AstKind, Trivias, Visit};
use oxc_diagnostics::Error; use oxc_diagnostics::Error;
use oxc_span::{CompactStr, SourceType, Span}; use oxc_span::{CompactStr, SourceType, Span};
use oxc_syntax::{ use oxc_syntax::{
identifier::is_identifier_name,
module_record::{ExportImportName, ExportLocalName, ModuleRecord}, module_record::{ExportImportName, ExportLocalName, ModuleRecord},
operator::AssignmentOperator, operator::AssignmentOperator,
}; };
@ -333,10 +334,23 @@ impl<'a> SemanticBuilder<'a> {
}); });
self.module_record.local_export_entries.iter().for_each(|entry| { self.module_record.local_export_entries.iter().for_each(|entry| {
if let ExportLocalName::Name(name_span) = &entry.local_name { match &entry.local_name {
if let Some(symbol_id) = self.scope.get_root_binding(name_span.name()) { ExportLocalName::Name(name_span) => {
self.symbols.union_flag(symbol_id, SymbolFlags::Export); if let Some(symbol_id) = self.scope.get_root_binding(name_span.name()) {
self.symbols.union_flag(symbol_id, SymbolFlags::Export);
}
} }
ExportLocalName::Default(_) => {
// export default identifier
// ^^^^^^^^^^
let identifier = entry.span.source_text(self.source_text);
if is_identifier_name(identifier) {
if let Some(symbol_id) = self.scope.get_root_binding(identifier) {
self.symbols.union_flag(symbol_id, SymbolFlags::Export);
}
}
}
ExportLocalName::Null => {}
} }
}); });
} }

2
crates/oxc_semantic/tests/symbols.rs
View file

@ -92,7 +92,7 @@ fn test_export_flag() {
let tester = SemanticTester::js( let tester = SemanticTester::js(
" "
const a = 1; const a = 1;
export { a, b, c as d }; export { a, b as d };
class b {} class b {}
export default c; export default c;
function c() {} function c() {}