dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter/no-unused-vars): give argsIgnorePattern the same default behavior as varsIgnorePattern (#5018)

Browse source
This commit is contained in:
DonIsaac 2024-08-21 00:15:10 +00:00
parent 5a55dcf39b
commit 9354779ad4
1 changed files with 20 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
crates/oxc_linter/src/rules/eslint/no_unused_vars/options.rs
View file

@ -50,7 +50,10 @@ pub struct NoUnusedVarsOptions {
/// Specifies exceptions to this rule for unused arguments. Arguments whose /// Specifies exceptions to this rule for unused arguments. Arguments whose
/// names match this pattern will be ignored. /// names match this pattern will be ignored.
/// ///
/// By default this pattern is [`None`]. /// By default, this pattern is `^_` unless options are configured with an
/// object. In this case it will default to [`None`]. Note that this
/// behavior deviates from both ESLint and TypeScript-ESLint, which never
/// provide a default pattern.
/// ///
/// ## Example /// ## Example
/// ///
@ -206,11 +209,12 @@ pub struct NoUnusedVarsOptions {
impl Default for NoUnusedVarsOptions { impl Default for NoUnusedVarsOptions {
fn default() -> Self { fn default() -> Self {
let underscore = Some(Regex::new("^_").unwrap());
Self { Self {
vars: VarsOption::default(), vars: VarsOption::default(),
vars_ignore_pattern: Some(Regex::new("^_").unwrap()), vars_ignore_pattern: underscore.clone(),
args: ArgsOption::default(), args: ArgsOption::default(),
args_ignore_pattern: None, args_ignore_pattern: underscore,
ignore_rest_siblings: false, ignore_rest_siblings: false,
caught_errors: CaughtErrors::default(), caught_errors: CaughtErrors::default(),
caught_errors_ignore_pattern: None, caught_errors_ignore_pattern: None,
@ -506,7 +510,7 @@ mod tests {
assert_eq!(rule.vars, VarsOption::All); assert_eq!(rule.vars, VarsOption::All);
assert!(rule.vars_ignore_pattern.is_some_and(|v| v.as_str() == "^_")); assert!(rule.vars_ignore_pattern.is_some_and(|v| v.as_str() == "^_"));
assert_eq!(rule.args, ArgsOption::AfterUsed); assert_eq!(rule.args, ArgsOption::AfterUsed);
assert!(rule.args_ignore_pattern.is_none()); assert!(rule.args_ignore_pattern.is_some_and(|v| v.as_str() == "^_"));
assert_eq!(rule.caught_errors, CaughtErrors::all()); assert_eq!(rule.caught_errors, CaughtErrors::all());
assert!(rule.caught_errors_ignore_pattern.is_none()); assert!(rule.caught_errors_ignore_pattern.is_none());
assert!(rule.destructured_array_ignore_pattern.is_none()); assert!(rule.destructured_array_ignore_pattern.is_none());
@ -564,6 +568,17 @@ mod tests {
// option object provided, no default varsIgnorePattern // option object provided, no default varsIgnorePattern
assert!(rule.vars_ignore_pattern.is_none()); assert!(rule.vars_ignore_pattern.is_none());
assert!(rule.args_ignore_pattern.unwrap().as_str() == "^_"); assert!(rule.args_ignore_pattern.unwrap().as_str() == "^_");
let rule: NoUnusedVarsOptions = json!([
{
"varsIgnorePattern": "^_",
}
])
.into();
// option object provided, no default argsIgnorePattern
assert!(rule.vars_ignore_pattern.unwrap().as_str() == "^_");
assert!(rule.args_ignore_pattern.is_none());
} }
#[test] #[test]
@ -587,8 +602,7 @@ mod tests {
assert!(default.vars_ignore_pattern.unwrap().as_str() == "^_"); assert!(default.vars_ignore_pattern.unwrap().as_str() == "^_");
assert_eq!(opts.args, default.args); assert_eq!(opts.args, default.args);
assert!(opts.args_ignore_pattern.is_none()); assert!(default.args_ignore_pattern.unwrap().as_str() == "^_");
assert!(default.args_ignore_pattern.is_none());
assert_eq!(opts.caught_errors, default.caught_errors); assert_eq!(opts.caught_errors, default.caught_errors);
assert!(opts.caught_errors_ignore_pattern.is_none()); assert!(opts.caught_errors_ignore_pattern.is_none());