dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter): improve target span and message on isolated_declaration

Browse source
This commit is contained in:
Boshen 2023-03-26 19:55:01 +08:00
parent 929b0efebb
commit 90f043fe66
No known key found for this signature in database
GPG key ID: 9C7A8C8AB22BEBD1
2 changed files with 26 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
crates/oxc_linter/src/rules/typescript/isolated_declaration.rs
View file

@ -1,6 +1,6 @@
use oxc_ast::{
ast::{Class, ClassElement, Function, PropertyDefinition},
AstKind, Span,
AstKind, GetSpan, Span,
};
use oxc_diagnostics::{
miette::{self, Diagnostic},
@ -13,13 +13,15 @@ use crate::{ast_util::IsPrivate, context::LintContext, rule::Rule};
#[derive(Debug, Error, Diagnostic)]
enum IsolatedDeclarationDiagnostic {
#[error("isolated-declaration: Requires type annotation on non-private property definition")]
#[error("isolated-declaration: Requires type annotation on exported properties")]
#[diagnostic(severity(warning))]
Property(#[label] Span),
#[error("isolated-declaration: Requires type annotation on parameters of non-private method")]
#[error("isolated-declaration: Requires type annotation on export parameters")]
#[diagnostic(severity(warning))]
FunctionParam(#[label] Span),
#[error("isolated-declaration: Requires return type annotation of non-private method")]
#[error("isolated-declaration: Requires return type annotation on exported functions")]
#[diagnostic(severity(warning))]
FunctionReturnType(#[label] Span),
}
@ -85,14 +87,16 @@ impl IsolatedDeclaration {
}
}
if function.return_type.is_none() {
ctx.diagnostic(IsolatedDeclarationDiagnostic::FunctionReturnType(function.span));
let start = function.params.span.end;
let span = Span::new(start, start + 1);
ctx.diagnostic(IsolatedDeclarationDiagnostic::FunctionReturnType(span));
}
}
/// Checks that the property as a type annotation
pub fn check_property_definition(property: &PropertyDefinition, ctx: &LintContext<'_>) {
if property.type_annotation.is_none() {
ctx.diagnostic(IsolatedDeclarationDiagnostic::Property(property.span));
ctx.diagnostic(IsolatedDeclarationDiagnostic::Property(property.key.span()));
}
}

32
crates/oxc_linter/src/snapshots/isolated_declaration.snap
View file

@ -3,57 +3,57 @@ source: crates/oxc_linter/src/tester.rs
expression: isolated_declaration
---
⚠ isolated-declaration: Requires type annotation on parameters of non-private method
⚠ isolated-declaration: Requires type annotation on export parameters
╭─[isolated_declaration.tsx:1:1]
1 │ export function foo(a) { return a; }
· ─
╰────
⚠ isolated-declaration: Requires return type annotation of non-private method
⚠ isolated-declaration: Requires return type annotation on exported functions
╭─[isolated_declaration.tsx:1:1]
1 │ export function foo(a) { return a; }
· ─────────────────────────────
· ─
╰────
⚠ isolated-declaration: Requires type annotation on non-private property definition
⚠ isolated-declaration: Requires type annotation on exported properties
╭─[isolated_declaration.tsx:1:1]
1 │ export class A { public a; }
· ─────────
· ─
╰────
⚠ isolated-declaration: Requires return type annotation of non-private method
⚠ isolated-declaration: Requires return type annotation on exported functions
╭─[isolated_declaration.tsx:1:1]
1 │ export class A { foo() { return 0; } }
· ────────────────
· ─
╰────
⚠ isolated-declaration: Requires return type annotation of non-private method
⚠ isolated-declaration: Requires return type annotation on exported functions
╭─[isolated_declaration.tsx:1:1]
1 │ export abstract class A { abstract foo() { return 0; } }
· ────────────────
· ─
╰────
⚠ isolated-declaration: Requires type annotation on non-private property definition
⚠ isolated-declaration: Requires type annotation on exported properties
╭─[isolated_declaration.tsx:1:1]
1 │ export abstract class A { abstract a; }
· ───────────
· ─
╰────
⚠ isolated-declaration: Requires return type annotation of non-private method
⚠ isolated-declaration: Requires return type annotation on exported functions
╭─[isolated_declaration.tsx:1:1]
1 │ export class A { get foo() { return 0; } }
· ────────────────
· ─
╰────
⚠ isolated-declaration: Requires type annotation on parameters of non-private method
⚠ isolated-declaration: Requires type annotation on export parameters
╭─[isolated_declaration.tsx:1:1]
1 │ export class A { set foo(val) { } }
· ───
╰────
⚠ isolated-declaration: Requires return type annotation of non-private method
⚠ isolated-declaration: Requires return type annotation on exported functions
╭─[isolated_declaration.tsx:1:1]
1 │ export class A { set foo(val) { } }
· ─────────
· ─
╰────