From 8cf7c130a4fe79f80498a94e18548472aa1f4743 Mon Sep 17 00:00:00 2001 From: Boshen Date: Fri, 28 Apr 2023 22:15:58 +0800 Subject: [PATCH] refactor(ast): s/visit_pattern/visit_binding_pattern --- crates/oxc_ast/src/visit.rs | 16 ++++++++-------- crates/oxc_ast/src/visit_mut.rs | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/crates/oxc_ast/src/visit.rs b/crates/oxc_ast/src/visit.rs index dc959eaae..5e090973f 100644 --- a/crates/oxc_ast/src/visit.rs +++ b/crates/oxc_ast/src/visit.rs @@ -241,7 +241,7 @@ pub trait Visit<'a>: Sized { let kind = AstKind::CatchClause(clause); self.enter_node(kind); if let Some(param) = &clause.param { - self.visit_pattern(param); + self.visit_binding_pattern(param); } self.visit_statements(&clause.body.body); self.leave_node(kind); @@ -291,7 +291,7 @@ pub trait Visit<'a>: Sized { fn visit_variable_declarator(&mut self, declarator: &'a VariableDeclarator<'a>) { let kind = AstKind::VariableDeclarator(declarator); self.enter_node(kind); - self.visit_pattern(&declarator.id); + self.visit_binding_pattern(&declarator.id); if let Some(init) = &declarator.init { self.visit_expression(init); } @@ -344,7 +344,7 @@ pub trait Visit<'a>: Sized { for decorator in ¶m.decorators { self.visit_decorator(decorator); } - self.visit_pattern(¶m.pattern); + self.visit_binding_pattern(¶m.pattern); self.leave_node(kind); } @@ -704,7 +704,7 @@ pub trait Visit<'a>: Sized { let kind = AstKind::PropertyValue(value); self.enter_node(kind); match value { - PropertyValue::Pattern(pat) => self.visit_pattern(pat), + PropertyValue::Pattern(pat) => self.visit_binding_pattern(pat), PropertyValue::Expression(expr) => self.visit_expression(expr), } self.leave_node(kind); @@ -985,7 +985,7 @@ pub trait Visit<'a>: Sized { /* ---------- Pattern ---------- */ - fn visit_pattern(&mut self, pat: &'a BindingPattern<'a>) { + fn visit_binding_pattern(&mut self, pat: &'a BindingPattern<'a>) { match &pat.kind { BindingPatternKind::BindingIdentifier(ident) => { self.visit_binding_identifier(ident); @@ -1026,7 +1026,7 @@ pub trait Visit<'a>: Sized { let kind = AstKind::ArrayPattern(pat); self.enter_node(kind); for pat in pat.elements.iter().flatten() { - self.visit_pattern(pat); + self.visit_binding_pattern(pat); } self.leave_node(kind); } @@ -1034,14 +1034,14 @@ pub trait Visit<'a>: Sized { fn visit_rest_element(&mut self, pat: &'a RestElement<'a>) { let kind = AstKind::RestElement(pat); self.enter_node(kind); - self.visit_pattern(&pat.argument); + self.visit_binding_pattern(&pat.argument); self.leave_node(kind); } fn visit_assignment_pattern(&mut self, pat: &'a AssignmentPattern<'a>) { let kind = AstKind::AssignmentPattern(pat); self.enter_node(kind); - self.visit_pattern(&pat.left); + self.visit_binding_pattern(&pat.left); self.visit_expression(&pat.right); self.leave_node(kind); } diff --git a/crates/oxc_ast/src/visit_mut.rs b/crates/oxc_ast/src/visit_mut.rs index 466ff3c20..76ca996a0 100644 --- a/crates/oxc_ast/src/visit_mut.rs +++ b/crates/oxc_ast/src/visit_mut.rs @@ -173,7 +173,7 @@ pub trait VisitMut<'a, 'b>: Sized { fn visit_catch_clause(&mut self, clause: &'b mut CatchClause<'a>) { if let Some(param) = &mut clause.param { - self.visit_pattern(param); + self.visit_binding_pattern(param); } self.visit_statements(&mut clause.body.body); } @@ -205,7 +205,7 @@ pub trait VisitMut<'a, 'b>: Sized { } fn visit_variable_declarator(&mut self, declarator: &'b mut VariableDeclarator<'a>) { - self.visit_pattern(&mut declarator.id); + self.visit_binding_pattern(&mut declarator.id); if let Some(init) = &mut declarator.init { self.visit_expression(init); } @@ -246,7 +246,7 @@ pub trait VisitMut<'a, 'b>: Sized { for decorator in param.decorators.iter_mut() { self.visit_decorator(decorator); } - self.visit_pattern(&mut param.pattern); + self.visit_binding_pattern(&mut param.pattern); } /* ---------- Class ---------- */ @@ -533,7 +533,7 @@ pub trait VisitMut<'a, 'b>: Sized { fn visit_property_value(&mut self, value: &'b mut PropertyValue<'a>) { match value { - PropertyValue::Pattern(pat) => self.visit_pattern(pat), + PropertyValue::Pattern(pat) => self.visit_binding_pattern(pat), PropertyValue::Expression(expr) => self.visit_expression(expr), } } @@ -771,7 +771,7 @@ pub trait VisitMut<'a, 'b>: Sized { /* ---------- Pattern ---------- */ - fn visit_pattern(&mut self, pat: &'b mut BindingPattern<'a>) { + fn visit_binding_pattern(&mut self, pat: &'b mut BindingPattern<'a>) { match &mut pat.kind { BindingPatternKind::BindingIdentifier(ident) => { self.visit_binding_identifier(ident); @@ -803,16 +803,16 @@ pub trait VisitMut<'a, 'b>: Sized { fn visit_array_pattern(&mut self, pat: &'b mut ArrayPattern<'a>) { for pat in pat.elements.iter_mut().flatten() { - self.visit_pattern(pat); + self.visit_binding_pattern(pat); } } fn visit_rest_element(&mut self, pat: &'b mut RestElement<'a>) { - self.visit_pattern(&mut pat.argument); + self.visit_binding_pattern(&mut pat.argument); } fn visit_assignment_pattern(&mut self, pat: &'b mut AssignmentPattern<'a>) { - self.visit_pattern(&mut pat.left); + self.visit_binding_pattern(&mut pat.left); self.visit_expression(&mut pat.right); }