dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(codegen): missing parens for in in for in loop init (#7705)

Browse source 
Well, this looks like an accidental change before, `Context::empty().and_forbid_in(false)` does nothing at all.
This commit is contained in:
Dunqing 2024-12-06 15:52:05 +00:00
parent 4afbe5599e
commit 8c3a954336
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_codegen/src/gen.rs
View file

@ -291,7 +291,7 @@ impl Gen for ForInStatement<'_> {
p.print_str("for"); p.print_str("for");
p.print_soft_space(); p.print_soft_space();
p.print_ascii_byte(b'('); p.print_ascii_byte(b'(');
self.left.print(p, Context::empty().and_forbid_in(false)); self.left.print(p, Context::FORBID_IN);
p.print_soft_space(); p.print_soft_space();
p.print_space_before_identifier(); p.print_space_before_identifier();
p.print_str("in"); p.print_str("in");

8
crates/oxc_codegen/tests/integration/unit.rs
View file

@ -64,10 +64,10 @@ fn for_stmt() {
"for (x = (y in z) || y || (y in z) || y || (y in z);;);", "for (x = (y in z) || y || (y in z) || y || (y in z);;);",
"for (x = (y in z) || y || (y in z) || y || (y in z);;);\n", "for (x = (y in z) || y || (y in z) || y || (y in z);;);\n",
); );
// test( test(
// "for (var a = 1 || (2 in {}) in { x: 1 }) count++;", "for (var a = 1 || (2 in {}) in { x: 1 }) count++;",
// "for (var a = 1 || (2 in {}) in {x: 1}) count++;\n", "for (var a = 1 || (2 in {}) in { x: 1 }) count++;\n",
// ); );
} }
#[test] #[test]