dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer/arrow-function): comments on possible improvement (#7320)

Browse source
This commit is contained in:
overlookmotel 2024-11-17 05:08:59 +00:00 committed by overlookmotel
parent ea08c1f495
commit 871e19bea2
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_transformer/src/common/arrow_function_converter.rs
View file

@ -748,6 +748,8 @@ impl<'a> ArrowFunctionConverter<'a> {
// Create a parameter for the prop if it's a computed member expression. // Create a parameter for the prop if it's a computed member expression.
if is_computed { if is_computed {
// TODO(improve-on-babel): No need for UID here. Just `prop` would be fine as there's nothing
// in `prop => super[prop]` or `(prop, value) => super[prop] = value` which can clash.
let param_binding = let param_binding =
ctx.generate_uid("prop", scope_id, SymbolFlags::FunctionScopedVariable); ctx.generate_uid("prop", scope_id, SymbolFlags::FunctionScopedVariable);
let param = ctx.ast.formal_parameter( let param = ctx.ast.formal_parameter(
@ -771,6 +773,8 @@ impl<'a> ArrowFunctionConverter<'a> {
// Create a parameter for the value if it's an assignment. // Create a parameter for the value if it's an assignment.
if is_assignment { if is_assignment {
// TODO(improve-on-babel): No need for UID here. Just `value` would be fine as there's nothing
// in `value => super.prop = value` or `(prop, value) => super[prop] = value` which can clash.
let param_binding = let param_binding =
ctx.generate_uid("value", scope_id, SymbolFlags::FunctionScopedVariable); ctx.generate_uid("value", scope_id, SymbolFlags::FunctionScopedVariable);
let param = ctx.ast.formal_parameter( let param = ctx.ast.formal_parameter(