dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

style(transformer/common): Split up StatementInjectorStore methods into blocks (#7042)

Browse source 
Pure refactor. Split up the `impl`s into multiple blocks with comments for each block, to make it clearer.
This commit is contained in:
overlookmotel 2024-10-31 19:23:28 +00:00
parent fcaba4a92a
commit 86ab091e42
1 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
crates/oxc_transformer/src/common/statement_injector.rs
View file

@ -60,20 +60,24 @@ pub struct StatementInjectorStore<'a> {
insertions: RefCell<FxHashMap<Address, Vec<AdjacentStatement<'a>>>>, insertions: RefCell<FxHashMap<Address, Vec<AdjacentStatement<'a>>>>,
} }
// Public methods
impl<'a> StatementInjectorStore<'a> { impl<'a> StatementInjectorStore<'a> {
/// Create new `StatementInjectorStore`. /// Create new `StatementInjectorStore`.
pub fn new() -> Self { pub fn new() -> Self {
Self { insertions: RefCell::new(FxHashMap::default()) } Self { insertions: RefCell::new(FxHashMap::default()) }
} }
}
// Each of the `insert_before` / `insert_after` functions is split into 2 parts: // Insertion methods.
// //
// 1. Outer function which is generic over any `GetAddress`. // Each of these functions is split into 2 parts:
// 2. Inner function which is non-generic and takes `Address`. //
// // 1. Public outer function which is generic over any `GetAddress`.
// Outer functions are marked `#[inline]`, as `GetAddress::address` is generally only 1 or 2 instructions. // 2. Private inner function which is non-generic and takes `Address`.
// The non-trivial inner functions are not marked `#[inline]` - compiler can decide whether to inline or not. //
// Outer functions are marked `#[inline]`, as `GetAddress::address` is generally only 1 or 2 instructions.
// The non-trivial inner functions are not marked `#[inline]` - compiler can decide whether to inline or not.
impl<'a> StatementInjectorStore<'a> {
/// Add a statement to be inserted immediately before the target statement. /// Add a statement to be inserted immediately before the target statement.
#[expect(dead_code)] #[expect(dead_code)]
#[inline] #[inline]
@ -145,7 +149,10 @@ impl<'a> StatementInjectorStore<'a> {
stmts.into_iter().map(|stmt| AdjacentStatement { stmt, direction: Direction::After }), stmts.into_iter().map(|stmt| AdjacentStatement { stmt, direction: Direction::After }),
); );
} }
}
// Internal methods
impl<'a> StatementInjectorStore<'a> {
/// Insert statements immediately before / after the target statement. /// Insert statements immediately before / after the target statement.
fn insert_into_statements( fn insert_into_statements(
&self, &self,