dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(codegen): missing parentheses if there is a pure comment before a NewExpression as a ComputedMemberExpression's callee (#6105)

Browse source 
refer to 332727499e/internal/js_printer/js_printer.go (L2544)
This commit is contained in:
Dunqing 2024-09-27 07:12:31 +00:00
parent 3ef248afbd
commit 8582ae3e91
3 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_codegen/src/gen.rs
View file

@ -1328,7 +1328,7 @@ impl<'a> GenExpr for ComputedMemberExpression<'a> {
// `(let[0] = 100);` -> `(let)[0] = 100`; // `(let[0] = 100);` -> `(let)[0] = 100`;
let wrap = self.object.get_identifier_reference().is_some_and(|r| r.name == "let"); let wrap = self.object.get_identifier_reference().is_some_and(|r| r.name == "let");
p.wrap(wrap, |p| { p.wrap(wrap, |p| {
self.object.print_expr(p, Precedence::Prefix, ctx.intersection(Context::FORBID_CALL)); self.object.print_expr(p, Precedence::Postfix, ctx.intersection(Context::FORBID_CALL));
}); });
if self.optional { if self.optional {
p.print_str("?."); p.print_str("?.");

2
crates/oxc_codegen/tests/integration/pure_comments.rs
View file

@ -111,6 +111,8 @@ const builtInSymbols = new Set(
"#, "#,
"(/* @__PURE__ */ new Foo()).bar();\n", "(/* @__PURE__ */ new Foo()).bar();\n",
"(/* @__PURE__ */ Foo()).bar();\n", "(/* @__PURE__ */ Foo()).bar();\n",
"(/* @__PURE__ */ new Foo())['bar']();\n",
"(/* @__PURE__ */ Foo())['bar']();\n",
// https://github.com/oxc-project/oxc/issues/4843 // https://github.com/oxc-project/oxc/issues/4843
r" r"
/* #__NO_SIDE_EFFECTS__ */ /* #__NO_SIDE_EFFECTS__ */

14
crates/oxc_codegen/tests/integration/snapshots/pure_comments.snap
View file

@ -233,6 +233,18 @@ const builtInSymbols = new Set(
(/* @__PURE__ */ Foo()).bar(); (/* @__PURE__ */ Foo()).bar();
########## 16 ########## 16
(/* @__PURE__ */ new Foo())['bar']();
----------
(/* @__PURE__ */ new Foo())['bar']();
########## 17
(/* @__PURE__ */ Foo())['bar']();
----------
(/* @__PURE__ */ Foo())['bar']();
########## 18
/* #__NO_SIDE_EFFECTS__ */ /* #__NO_SIDE_EFFECTS__ */
const defineSSRCustomElement = /* @__NO_SIDE_EFFECTS__ */ ( const defineSSRCustomElement = /* @__NO_SIDE_EFFECTS__ */ (
@ -247,7 +259,7 @@ const defineSSRCustomElement = /* #__NO_SIDE_EFFECTS__ */ /* @__NO_SIDE_EFFECTS_
return /* @__PURE__ */ defineCustomElement(options, extraOptions, hydrate); return /* @__PURE__ */ defineCustomElement(options, extraOptions, hydrate);
}; };
########## 17 ########## 19
const defineSSRCustomElement = () => { const defineSSRCustomElement = () => {
return /* @__PURE__ */ /* @__NO_SIDE_EFFECTS__ */ /* #__NO_SIDE_EFFECTS__ */ defineCustomElement(options, extraOptions, hydrate); return /* @__PURE__ */ /* @__NO_SIDE_EFFECTS__ */ /* #__NO_SIDE_EFFECTS__ */ defineCustomElement(options, extraOptions, hydrate);