dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(codegen): converts line comment to block comment if it is a PURE comment (#6356)

Browse source 
The last part of fixing https://github.com/rolldown/rolldown/pull/2375/files#r1789011257

In the following case, the pure comment was written by `//`
```ts
const Component = // #__PURE__
React.forwardRef((props, ref) => {});
```

The printed code looks like this
```ts
const Component =
// #__PURE__ React.forwardRef((props, ref) => {});
```

As you can see, it is broken because the code also commented, so we need to replace `//` with `/* */`
This commit is contained in:
Dunqing 2024-10-08 05:42:42 +00:00
parent 1380d8b5dc
commit 84b2d072e8
3 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_codegen/src/comment.rs
View file

@ -140,7 +140,13 @@ impl<'a> Codegen<'a> {
if !Self::is_annotation_comment(&comment, source_text) {
continue;
}
self.print_str(comment.real_span().source_text(source_text));
if comment.is_line() {
self.print_str("/*");
self.print_str(comment.span.source_text(source_text));
self.print_str("*/");
} else {
self.print_str(comment.real_span().source_text(source_text));
}
self.print_hard_space();
}
}

4
crates/oxc_codegen/tests/integration/pure_comments.rs
View file

@ -129,6 +129,10 @@ const defineSSRCustomElement = () => {
return /* @__PURE__ */ /* @__NO_SIDE_EFFECTS__ */ /* #__NO_SIDE_EFFECTS__ */ defineCustomElement(options, extraOptions, hydrate);
};
",
"
const Component = // #__PURE__
React.forwardRef((props, ref) => {});
",
];
snapshot("pure_comments", &cases);

8
crates/oxc_codegen/tests/integration/snapshots/pure_comments.snap
View file

@ -269,3 +269,11 @@ const defineSSRCustomElement = () => {
const defineSSRCustomElement = () => {
return /* @__PURE__ */ /* @__NO_SIDE_EFFECTS__ */ /* #__NO_SIDE_EFFECTS__ */ defineCustomElement(options, extraOptions, hydrate);
};
########## 20
const Component = // #__PURE__
React.forwardRef((props, ref) => {});
----------
const Component = /* #__PURE__*/ React.forwardRef((props, ref) => {});