From 83f25fc9b36fdbe2d3627741942cd588588b45b9 Mon Sep 17 00:00:00 2001 From: Cameron Date: Tue, 28 Nov 2023 02:45:27 +0000 Subject: [PATCH] fix(prettier) fix printing of call args when in break mode (#1563) To test, format: ```ts foobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobar(); ``` Previously: ```ts foobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobar( , ); ``` Now: ```ts foobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobarfoobar(); ``` --- crates/oxc_prettier/src/format/call_expression.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/oxc_prettier/src/format/call_expression.rs b/crates/oxc_prettier/src/format/call_expression.rs index 91b3c1f38..c96bc3d85 100644 --- a/crates/oxc_prettier/src/format/call_expression.rs +++ b/crates/oxc_prettier/src/format/call_expression.rs @@ -74,8 +74,6 @@ fn print_call_expression_arguments<'a>( let mut parts = p.vec(); parts.push(ss!("(")); - let mut parts_inner = p.vec(); - let callee = expression.callee(); let arguments = expression.arguments(); let should_break = if matches!(expression, CallExpressionLike::CallExpression(_)) { @@ -86,8 +84,12 @@ fn print_call_expression_arguments<'a>( if arguments.is_empty() { parts.extend(p.print_inner_comment(Span::new(callee.span().end, expression.span().end))); + parts.push(ss!(")")); + return Doc::Array(parts); } + let mut parts_inner = p.vec(); + for (i, element) in arguments.iter().enumerate() { let doc = element.format(p); parts_inner.push(doc);