dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(isolated-declarations): use FxHashSet instead of Vec to speed up the contain (#4074)

Browse source
This commit is contained in:
Dunqing 2024-07-08 00:16:25 +08:00 committed by GitHub
parent 6e5447e5d5
commit 7ed27b75f9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
crates/oxc_isolated_declarations/src/lib.rs
View file

@ -121,7 +121,7 @@ impl<'a> IsolatedDeclarations<'a> {
let mut new_stmts = Vec::new(); let mut new_stmts = Vec::new();
let mut variables_declarations = VecDeque::new(); let mut variables_declarations = VecDeque::new();
let mut variable_transformed_indexes = VecDeque::new(); let mut variable_transformed_indexes = VecDeque::new();
let mut transformed_indexes = Vec::new(); let mut transformed_indexes = FxHashSet::default();
// 1. Collect all declarations, module declarations // 1. Collect all declarations, module declarations
// 2. Transform export declarations // 2. Transform export declarations
// 3. Collect all bindings / reference from module declarations // 3. Collect all bindings / reference from module declarations
@ -134,18 +134,18 @@ impl<'a> IsolatedDeclarations<'a> {
variables_declarations.push_back( variables_declarations.push_back(
self.ast.copy(&decl.declarations).into_iter().collect::<Vec<_>>(), self.ast.copy(&decl.declarations).into_iter().collect::<Vec<_>>(),
); );
variable_transformed_indexes.push_back(Vec::default()); variable_transformed_indexes.push_back(FxHashSet::default());
} }
Declaration::UsingDeclaration(decl) => { Declaration::UsingDeclaration(decl) => {
variables_declarations.push_back( variables_declarations.push_back(
self.ast.copy(&decl.declarations).into_iter().collect::<Vec<_>>(), self.ast.copy(&decl.declarations).into_iter().collect::<Vec<_>>(),
); );
variable_transformed_indexes.push_back(Vec::default()); variable_transformed_indexes.push_back(FxHashSet::default());
} }
Declaration::TSModuleDeclaration(decl) => { Declaration::TSModuleDeclaration(decl) => {
if decl.kind.is_global() { if decl.kind.is_global() {
self.scope.visit_ts_module_declaration(decl); self.scope.visit_ts_module_declaration(decl);
transformed_indexes.push(new_stmts.len()); transformed_indexes.insert(new_stmts.len());
} }
} }
_ => {} _ => {}
@ -155,7 +155,7 @@ impl<'a> IsolatedDeclarations<'a> {
match_module_declaration!(Statement) => { match_module_declaration!(Statement) => {
match stmt.to_module_declaration() { match stmt.to_module_declaration() {
ModuleDeclaration::ExportDefaultDeclaration(decl) => { ModuleDeclaration::ExportDefaultDeclaration(decl) => {
transformed_indexes.push(new_stmts.len()); transformed_indexes.insert(new_stmts.len());
if let Some((var_decl, new_decl)) = if let Some((var_decl, new_decl)) =
self.transform_export_default_declaration(decl) self.transform_export_default_declaration(decl)
{ {
@ -165,7 +165,7 @@ impl<'a> IsolatedDeclarations<'a> {
new_stmts.push(Statement::VariableDeclaration( new_stmts.push(Statement::VariableDeclaration(
self.ast.alloc(var_decl), self.ast.alloc(var_decl),
)); ));
transformed_indexes.push(new_stmts.len()); transformed_indexes.insert(new_stmts.len());
} }
self.scope.visit_export_default_declaration(&new_decl); self.scope.visit_export_default_declaration(&new_decl);
@ -180,7 +180,7 @@ impl<'a> IsolatedDeclarations<'a> {
} }
ModuleDeclaration::ExportNamedDeclaration(decl) => { ModuleDeclaration::ExportNamedDeclaration(decl) => {
transformed_indexes.push(new_stmts.len()); transformed_indexes.insert(new_stmts.len());
if let Some(new_decl) = self.transform_export_named_declaration(decl) { if let Some(new_decl) = self.transform_export_named_declaration(decl) {
self.scope.visit_declaration( self.scope.visit_declaration(
new_decl.declaration.as_ref().unwrap_or_else(|| unreachable!()), new_decl.declaration.as_ref().unwrap_or_else(|| unreachable!()),
@ -198,7 +198,7 @@ impl<'a> IsolatedDeclarations<'a> {
// We must transform this in the end, because we need to know all references // We must transform this in the end, because we need to know all references
} }
module_declaration => { module_declaration => {
transformed_indexes.push(new_stmts.len()); transformed_indexes.insert(new_stmts.len());
self.scope.visit_module_declaration(module_declaration); self.scope.visit_module_declaration(module_declaration);
} }
} }
@ -241,13 +241,13 @@ impl<'a> IsolatedDeclarations<'a> {
if let Some(decl) = self.transform_variable_declarator(declarator, true) { if let Some(decl) = self.transform_variable_declarator(declarator, true) {
self.scope.visit_variable_declarator(&decl); self.scope.visit_variable_declarator(&decl);
cur_transformed_indexes.push(ii); cur_transformed_indexes.insert(ii);
*declarator = decl; *declarator = decl;
} }
} }
} else if let Some(decl) = self.transform_declaration(decl, true) { } else if let Some(decl) = self.transform_declaration(decl, true) {
self.scope.visit_declaration(&decl); self.scope.visit_declaration(&decl);
transformed_indexes.push(i); transformed_indexes.insert(i);
*stmt = Statement::from(decl); *stmt = Statement::from(decl);
} }
} }
@ -280,7 +280,7 @@ impl<'a> IsolatedDeclarations<'a> {
), ),
); );
new_ast_stmts.push(Statement::VariableDeclaration(variables_declaration)); new_ast_stmts.push(Statement::VariableDeclaration(variables_declaration));
transformed_indexes.push(index); transformed_indexes.insert(index);
} }
} }
Statement::UsingDeclaration(decl) => { Statement::UsingDeclaration(decl) => {
@ -302,7 +302,7 @@ impl<'a> IsolatedDeclarations<'a> {
), ),
); );
new_ast_stmts.push(Statement::VariableDeclaration(variable_declaration)); new_ast_stmts.push(Statement::VariableDeclaration(variable_declaration));
transformed_indexes.push(index); transformed_indexes.insert(index);
} }
} }
Statement::ImportDeclaration(decl) => { Statement::ImportDeclaration(decl) => {