dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(semantic): delete the redundant code in binder (#2423)

Browse source
This commit is contained in:
Dunqing 2024-02-17 21:02:45 +08:00 committed by GitHub
parent 0b9e122de8
commit 7c2d868dc7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_semantic/src/binder.rs
View file

@ -43,11 +43,10 @@ impl<'a> Binder for VariableDeclarator<'a> {
let mut var_scope_ids = vec![]; let mut var_scope_ids = vec![];
if !builder.current_scope_flags().is_var() { if !builder.current_scope_flags().is_var() {
for scope_id in builder.scope.ancestors(current_scope_id).skip(1) { for scope_id in builder.scope.ancestors(current_scope_id).skip(1) {
var_scope_ids.push(scope_id);
if builder.scope.get_flags(scope_id).is_var() { if builder.scope.get_flags(scope_id).is_var() {
var_scope_ids.push(scope_id);
break; break;
} }
var_scope_ids.push(scope_id);
} }
} }
@ -60,10 +59,7 @@ impl<'a> Binder for VariableDeclarator<'a> {
builder.check_redeclaration(*scope_id, span, name, excludes, true) builder.check_redeclaration(*scope_id, span, name, excludes, true)
{ {
ident.symbol_id.set(Some(symbol_id)); ident.symbol_id.set(Some(symbol_id));
if self.kind.is_var() { builder.add_redeclared_variables(VariableInfo { span: ident.span, symbol_id });
builder
.add_redeclared_variables(VariableInfo { span: ident.span, symbol_id });
}
return; return;
} }
} }