dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): remove unsafe fixer of no-useless-spread (#6655)

Browse source 
closes #6618

---------

Co-authored-by: Boshen <boshenc@gmail.com>
This commit is contained in:
dalaoshu 2024-10-28 17:32:02 +08:00 committed by GitHub
parent 14f36ce3f9
commit 7aa496ab33
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 23 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
crates/oxc_linter/src/rules/unicorn/no_useless_spread/mod.rs
View file

@ -143,7 +143,7 @@ declare_oxc_lint!(
/// ```
NoUselessSpread,
correctness,
conditional_fix
fix_dangerous
);
impl Rule for NoUselessSpread {
@ -380,13 +380,13 @@ fn check_useless_clone<'a>(
is_array: bool,
spread_elem: &SpreadElement<'a>,
ctx: &LintContext<'a>,
) -> bool {
) {
let span = Span::new(spread_elem.span.start, spread_elem.span.start + 3);
let target = spread_elem.argument.get_inner_expression();
// already diagnosed by first check
if matches!(target, Expression::ArrayExpression(_) | Expression::ObjectExpression(_)) {
return false;
return;
}
let hint = target.const_eval();
@ -394,12 +394,29 @@ fn check_useless_clone<'a>(
if hint_matches_expr {
let name = diagnostic_name(ctx, target);
// `[...new Array(1)]` -> `new Array(1).fill()`
if let Expression::NewExpression(new_expr) = target {
let is_array_constructor = new_expr
.callee
.without_parentheses()
.get_identifier_reference()
.is_some_and(|id| id.name == "Array");
if is_array_constructor && new_expr.arguments.len() == 1 {
ctx.diagnostic_with_fix(clone(span, is_array, name), |fixer| {
fixer.replace(
array_or_obj_span,
format!("{}.fill()", fixer.source_range(spread_elem.argument.span())),
)
});
return;
}
}
ctx.diagnostic_with_fix(clone(span, is_array, name), |fixer| {
fix_by_removing_array_spread(fixer, &array_or_obj_span, spread_elem)
});
return true;
}
false
}
fn diagnostic_name<'a>(ctx: &LintContext<'a>, expr: &Expression<'a>) -> Option<&'a str> {
@ -725,6 +742,7 @@ fn test() {
// useless clones - simple arrays
("[...foo.map(x => !!x)]", "foo.map(x => !!x)"),
("[...new Array()]", "new Array()"),
("[...new Array(3)]", "new Array(3).fill()"),
("[...new Array(1, 2, 3)]", "new Array(1, 2, 3)"),
// useless clones - complex
(r"[...await Promise.all(foo)]", r"await Promise.all(foo)"),